You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/07/13 22:59:12 UTC
[GitHub] [incubator-pinot] jackjlli opened a new issue #5694: Increase code coverage for pinot-java-client
jackjlli opened a new issue #5694:
URL: https://github.com/apache/incubator-pinot/issues/5694
This is a sub-issue of #5150.
The goal is to increase the code coverage of pinot-java-client to at least 75%
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] ayush-bajaj commented on issue #5694: Increase code coverage for pinot-java-client
Posted by GitBox <gi...@apache.org>.
ayush-bajaj commented on issue #5694:
URL: https://github.com/apache/incubator-pinot/issues/5694#issuecomment-770727546
hey @jackjlli, I've responded to one of your comments. can you please take a look whenever you get a chance to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli commented on issue #5694: Increase code coverage for pinot-java-client
Posted by GitBox <gi...@apache.org>.
jackjlli commented on issue #5694:
URL: https://github.com/apache/incubator-pinot/issues/5694#issuecomment-730561378
Thanks, please do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] ayush-bajaj commented on issue #5694: Increase code coverage for pinot-java-client
Posted by GitBox <gi...@apache.org>.
ayush-bajaj commented on issue #5694:
URL: https://github.com/apache/incubator-pinot/issues/5694#issuecomment-730159898
Hi, can I take this up for implementation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] ayush-bajaj commented on issue #5694: Increase code coverage for pinot-java-client
Posted by GitBox <gi...@apache.org>.
ayush-bajaj commented on issue #5694:
URL: https://github.com/apache/incubator-pinot/issues/5694#issuecomment-758567418
Hey, I've added the test cases, please review whenever you get a chance to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] ayush-bajaj commented on issue #5694: Increase code coverage for pinot-java-client
Posted by GitBox <gi...@apache.org>.
ayush-bajaj commented on issue #5694:
URL: https://github.com/apache/incubator-pinot/issues/5694#issuecomment-773849731
Hey, made the suggested changes and all the tests have passed. can you please take a look at it again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] ayush-bajaj commented on issue #5694: Increase code coverage for pinot-java-client
Posted by GitBox <gi...@apache.org>.
ayush-bajaj commented on issue #5694:
URL: https://github.com/apache/incubator-pinot/issues/5694#issuecomment-773849731
Hey, made the suggested changes and all the tests have passed. can you please take a look at it again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org