You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/09/14 18:26:42 UTC

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #5756: AWS: Preload S3 client in GlueCatalog For LakeFormation enabled tables

amogh-jahagirdar commented on code in PR #5756:
URL: https://github.com/apache/iceberg/pull/5756#discussion_r971161799


##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##########
@@ -83,7 +88,8 @@ class GlueTableOperations extends BaseMetastoreTableOperations {
       LockManager lockManager,
       String catalogName,
       AwsProperties awsProperties,
-      FileIO fileIO,
+      Map<String, String> tableSpecificCatalogProperties,

Review Comment:
   Can this just be called tableCatalogProperties?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org