Re: [PR] [GLUTEN-10818][VL] Implement KnownSizeEstimation for buildSideRelation [incubator-gluten]

["zhztheplayer (via GitHub)" <gi...@apache.org>]

zhztheplayer commented on code in PR #10817:
URL: https://github.com/apache/incubator-gluten/pull/10817#discussion_r2394087649


##########
backends-velox/src/main/scala/org/apache/spark/sql/execution/ColumnarBuildSideRelation.scala:
##########
@@ -236,4 +238,11 @@ case class ColumnarBuildSideRelation(
     }
     iterator.toArray
   }
+  override def estimatedSize: Long = {
+    if (null != batches) {

Review Comment:
   Curious when will the batches be null?



##########
backends-velox/src/main/scala/org/apache/spark/sql/execution/unsafe/UnsafeColumnarBuildSideRelation.scala:
##########
@@ -366,4 +367,12 @@ case class UnsafeColumnarBuildSideRelation(
     }
     iterator.toArray
   }
+
+  override def estimatedSize: Long = {
+    if (null != batches) {

Review Comment:
   nit: Can we just use `batches != null`? It's more consistent with our current coding style.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org