You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/11/11 03:29:25 UTC

[GitHub] [incubator-devlake] klesh commented on issue #2078: Relocate files/dirs

klesh commented on issue #2078:
URL: https://github.com/apache/incubator-devlake/issues/2078#issuecomment-1311186179

   > @klesh
   > 
   > 1. Do you have any suggestions for where any framework-level python code should go (from [[Feature][Python plugin SDK] Support plugin development in Python #3701](https://github.com/apache/incubator-devlake/issues/3701))? Should we create a top level directory called "python" and throw all *.py files in there? Or should we place them next to the *.go files at the appropriate places? (I personally prefer the first option because it keeps things well-isolated)
   > 2. I've used the scripts folder for the model generator of Singer taps ([[Feature][Framework][POC] Streamed data collection using Singer Spec #3123](https://github.com/apache/incubator-devlake/issues/3123)). Do we still want to remove it?
   > 
   > cc @CamilleTeruel
   
   @keon94
   1. I think the top-level directory makes sense. Everything related to python-support should be put into it including *.go files if they are meant for python plugin support
   2. I don't have an opinion on this, it is up to you to judge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org