You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/05 01:48:48 UTC
[GitHub] [spark] xinrong-databricks commented on a change in pull request #32698: [SPARK-35341][PYTHON] Introduce BooleanExtensionOps
xinrong-databricks commented on a change in pull request #32698:
URL: https://github.com/apache/spark/pull/32698#discussion_r645924119
##########
File path: python/pyspark/pandas/tests/data_type_ops/test_boolean_ops.py
##########
@@ -228,9 +230,272 @@ def test_rmod(self):
self.assertRaises(TypeError, lambda: datetime.date(1994, 1, 1) % self.psser)
self.assertRaises(TypeError, lambda: True % self.psser)
+ def test_and(self):
+ pser = pd.Series([True, False, None], dtype='bool')
+ psser = ps.from_pandas(pser)
+ self.assert_eq(pser & True, psser & True)
+ self.assert_eq(pser & False, psser & False)
+ self.assert_eq(pser & pser, psser & psser)
+
+ other_pser = pd.Series([False, None, True], dtype='bool')
+ other_psser = ps.from_pandas(other_pser)
+ with option_context("compute.ops_on_diff_frames", True):
+ self.assert_eq(pser & other_pser, psser & other_psser)
+ self.check_extension(
+ pser & other_pser.astype('boolean'), psser & other_psser.astype('boolean'))
+ self.assert_eq(other_pser & pser, other_psser & psser)
+
+ def test_rand(self):
+ pser = pd.Series([True, False, None], dtype='bool')
+ psser = ps.from_pandas(pser)
+ self.assert_eq(True & pser, True & psser)
+ self.assert_eq(False & pser, False & psser)
+
+ def test_or(self):
+ pser = pd.Series([True, False, None], dtype='bool')
+ psser = ps.from_pandas(pser)
+ self.assert_eq(pser | True, psser | True)
+ self.assert_eq(pser | False, psser | False)
+ self.assert_eq(pser | pser, psser | psser)
+ self.assert_eq(True | pser, True | psser)
+ self.assert_eq(False | pser, False | psser)
+
+ other_pser = pd.Series([False, None, True], dtype='bool')
+ other_psser = ps.from_pandas(other_pser)
+ with option_context("compute.ops_on_diff_frames", True):
+ self.assert_eq(pser | other_pser, psser | other_psser)
+ self.check_extension(
+ pser | other_pser.astype('boolean'), psser | other_psser.astype('boolean'))
+ self.assert_eq(other_pser | pser, other_psser | psser)
+
+ def test_ror(self):
+ pser = pd.Series([True, False, None], dtype='bool')
+ psser = ps.from_pandas(pser)
+ self.assert_eq(True | pser, True | psser)
+ self.assert_eq(False | pser, False | psser)
+
+
+@unittest.skipIf(
+ not extension_dtypes_available, "pandas extension dtypes are not available"
+)
+class BooleanExtensionOpsTest(BooleanOpsTest, PandasOnSparkTestCase, TestCasesUtils):
Review comment:
Makes sense! Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org