You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jena.apache.org by ki...@apache.org on 2024/10/12 15:03:48 UTC
(jena) branch GH-2767-fix-js-warnings created (now 55eabedeec)
This is an automated email from the ASF dual-hosted git repository.
kinow pushed a change to branch GH-2767-fix-js-warnings
in repository https://gitbox.apache.org/repos/asf/jena.git
at 55eabedeec GH-2767: Use qs instead of queryString (more users, focus on security - qs was coming via Express, query-string via zazuko, we used both)
This branch includes the following new commits:
new e30971a9b0 GH-2767: add dependencies used but not listed in package.json
new 736e77c2ec GH-2767: Fix jsdoc type
new 2167dc7dcd GH-2767: Fix possible bug: response.statusCode is int, status is a callable (and grammar/typo warnings)
new 675d1b9c50 GH-2767: Use _ for param name to ignore unused arg
new 7853861f21 GH-2767: Import component used in the template
new 55eabedeec GH-2767: Use qs instead of queryString (more users, focus on security - qs was coming via Express, query-string via zazuko, we used both)
The 6 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(jena) 03/06: GH-2767: Fix possible bug: response.statusCode is int, status is a callable (and grammar/typo warnings)
Posted by ki...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
kinow pushed a commit to branch GH-2767-fix-js-warnings
in repository https://gitbox.apache.org/repos/asf/jena.git
commit 2167dc7dcdaa682086f23f7d9a2766b83aa19702
Author: Bruno P. Kinoshita <ki...@users.noreply.github.com>
AuthorDate: Sat Oct 12 17:01:32 2024 +0200
GH-2767: Fix possible bug: response.statusCode is int, status is a callable (and grammar/typo warnings)
---
jena-fuseki2/jena-fuseki-ui/src/services/fuseki.service.js | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/jena-fuseki2/jena-fuseki-ui/src/services/fuseki.service.js b/jena-fuseki2/jena-fuseki-ui/src/services/fuseki.service.js
index a090ec17f4..1537ccff54 100644
--- a/jena-fuseki2/jena-fuseki-ui/src/services/fuseki.service.js
+++ b/jena-fuseki2/jena-fuseki-ui/src/services/fuseki.service.js
@@ -16,6 +16,8 @@
*/
import axios from 'axios'
+// eslint-disable-next-line no-unused-vars
+import { AxiosResponse } from 'axios'
import qs from 'qs'
import ServerStatus from '@/model/server.status'
import { BUS } from '@/events'
@@ -33,7 +35,7 @@ class FusekiService {
}
/**
- * Gets the Fuseki URL, only the pathname onward. The protocol, server, port, etc,
+ * Gets the Fuseki URL, only the pathname onward. The protocol, server, port, etc.,
* are left to the browser/JS engine & Vue to choose. Previously we were passing
* strings such as `/#/ping$`. But this did not work when the application was
* deployed on a Tomcat server, for example, where the base URL could be something
@@ -142,8 +144,8 @@ class FusekiService {
})
} catch (error) {
if (error.response) {
- if (error.response.status !== 200) {
- if (error.response.status === 409) {
+ if (error.response.statusCode !== 200) {
+ if (error.response.statusCode === 409) {
throw new Error(`failed to create dataset "${datasetName}", reason: there is another dataset with the same name`)
}
throw new Error(`failed to create dataset "${datasetName}" with type ${datasetType}, reason: HTTP status: "${error.response.status}", message: ${error.response.statusText}`)
@@ -184,7 +186,7 @@ class FusekiService {
/**
* Get the data endpoint out of a list of server endpoints.
*
- * For now we are simply returning the first non-empty, but that
+ * For now, we are simply returning the first non-empty, but that
* may change at some point.
*
* @private
(jena) 06/06: GH-2767: Use qs instead of queryString (more users, focus on security - qs was coming via Express, query-string via zazuko, we used both)
Posted by ki...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
kinow pushed a commit to branch GH-2767-fix-js-warnings
in repository https://gitbox.apache.org/repos/asf/jena.git
commit 55eabedeecd94988bd84a2138c037b77c342c813
Author: Bruno P. Kinoshita <ki...@users.noreply.github.com>
AuthorDate: Sat Oct 12 17:03:10 2024 +0200
GH-2767: Use qs instead of queryString (more users, focus on security - qs was coming via Express, query-string via zazuko, we used both)
---
jena-fuseki2/jena-fuseki-ui/src/utils/query.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/jena-fuseki2/jena-fuseki-ui/src/utils/query.js b/jena-fuseki2/jena-fuseki-ui/src/utils/query.js
index edb841674f..68d22e5617 100644
--- a/jena-fuseki2/jena-fuseki-ui/src/utils/query.js
+++ b/jena-fuseki2/jena-fuseki-ui/src/utils/query.js
@@ -22,7 +22,7 @@
* instantiate a complete component or view.
*/
-import queryString from 'query-string'
+import qs from 'qs'
/**
* Create a shareable link using the value of the SPARQL query in the
@@ -49,6 +49,6 @@ export function createShareableLink (query, path) {
path +
'?' +
// Same as YASGUI does, good idea to avoid security problems...
- queryString.stringify({ query })
+ qs.stringify({ query })
)
}
(jena) 05/06: GH-2767: Import component used in the template
Posted by ki...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
kinow pushed a commit to branch GH-2767-fix-js-warnings
in repository https://gitbox.apache.org/repos/asf/jena.git
commit 7853861f213da4c93a2138fc7884f9a5790c253b
Author: Bruno P. Kinoshita <ki...@users.noreply.github.com>
AuthorDate: Sat Oct 12 17:02:31 2024 +0200
GH-2767: Import component used in the template
---
jena-fuseki2/jena-fuseki-ui/src/App.vue | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/jena-fuseki2/jena-fuseki-ui/src/App.vue b/jena-fuseki2/jena-fuseki-ui/src/App.vue
index 25195ba7f8..bb7d847ddd 100644
--- a/jena-fuseki2/jena-fuseki-ui/src/App.vue
+++ b/jena-fuseki2/jena-fuseki-ui/src/App.vue
@@ -29,11 +29,13 @@
<script>
import Menu from '@/components/Menu.vue'
+import Toast from '@/components/Toast.vue'
export default {
name: 'App',
components: {
- Menu
+ Menu,
+ Toast
}
}
</script>
(jena) 01/06: GH-2767: add dependencies used but not listed in package.json
Posted by ki...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
kinow pushed a commit to branch GH-2767-fix-js-warnings
in repository https://gitbox.apache.org/repos/asf/jena.git
commit e30971a9b064992f3b9ca11aeffd45d313266a78
Author: Bruno P. Kinoshita <ki...@users.noreply.github.com>
AuthorDate: Sat Oct 12 17:00:41 2024 +0200
GH-2767: add dependencies used but not listed in package.json
---
jena-fuseki2/jena-fuseki-ui/package.json | 3 +++
jena-fuseki2/jena-fuseki-ui/yarn.lock | 21 ++++++++++++++++++++-
2 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/jena-fuseki2/jena-fuseki-ui/package.json b/jena-fuseki2/jena-fuseki-ui/package.json
index a091752538..c92e814925 100644
--- a/jena-fuseki2/jena-fuseki-ui/package.json
+++ b/jena-fuseki2/jena-fuseki-ui/package.json
@@ -30,8 +30,10 @@
"@zazuko/yasr": "^4.2.34",
"axios": "^1.6.1",
"bootstrap": "^5.3.2",
+ "codemirror": "5.65.16",
"follow-redirects": "^1.15.4",
"mitt": "^3.0.1",
+ "qs": "6.13.0",
"vue": "^3.3.6",
"vue-router": "^4.2.5",
"vue-upload-component": "^3.1.8"
@@ -40,6 +42,7 @@
"@cypress/code-coverage": "^3.12.4",
"@cypress/vue": "^6.0.0",
"@eslint/js": "^9.2.0",
+ "@types/codemirror": "^5.60.15",
"@vitejs/plugin-vue": "^5.0.3",
"@vitest/coverage-v8": "^2.0.4",
"@vue/compiler-sfc": "^3.3.6",
diff --git a/jena-fuseki2/jena-fuseki-ui/yarn.lock b/jena-fuseki2/jena-fuseki-ui/yarn.lock
index 787c7ba345..e2e0e15993 100644
--- a/jena-fuseki2/jena-fuseki-ui/yarn.lock
+++ b/jena-fuseki2/jena-fuseki-ui/yarn.lock
@@ -893,6 +893,18 @@
resolved "https://registry.yarnpkg.com/@streamparser/json/-/json-0.0.19.tgz#d9c264b54e366186ea4459bbb16c10238dc9e2a4"
integrity sha512-VTxtZGME6ZSWNCSjZ0Zd2LNNodx62XvmARb/liHIwGlInuuvoDzioLuRP8ajV8iLBknsTrsqpRDGlvzKSzpNEw==
+"@types/codemirror@^5.60.15":
+ version "5.60.15"
+ resolved "https://registry.yarnpkg.com/@types/codemirror/-/codemirror-5.60.15.tgz#0f82be6f4126d1e59cf4c4830e56dcd49d3c3e8a"
+ integrity sha512-dTOvwEQ+ouKJ/rE9LT1Ue2hmP6H1mZv5+CCnNWu2qtiOe2LQa9lCprEY20HxiDmV/Bxh+dXjywmy5aKvoGjULA==
+ dependencies:
+ "@types/tern" "*"
+
+"@types/estree@*":
+ version "1.0.6"
+ resolved "https://registry.yarnpkg.com/@types/estree/-/estree-1.0.6.tgz#628effeeae2064a1b4e79f78e81d87b7e5fc7b50"
+ integrity sha512-AYnb1nQyY49te+VRAVgmzfcgjYS91mY5P0TKUDCLEM+gNnA+3T6rWITXRLYCpahpqSQbN5cE+gHpnPyXjHWxcw==
+
"@types/estree@1.0.5", "@types/estree@^1.0.0":
version "1.0.5"
resolved "https://registry.yarnpkg.com/@types/estree/-/estree-1.0.5.tgz#a6ce3e556e00fd9895dd872dd172ad0d4bd687f4"
@@ -939,6 +951,13 @@
resolved "https://registry.yarnpkg.com/@types/sizzle/-/sizzle-2.3.6.tgz#e39b7123dac4631001939bd4c2a26d46010f2275"
integrity sha512-m04Om5Gz6kbjUwAQ7XJJQ30OdEFsSmAVsvn4NYwcTRyMVpKKa1aPuESw1n2CxS5fYkOQv3nHgDKeNa8e76fUkw==
+"@types/tern@*":
+ version "0.23.9"
+ resolved "https://registry.yarnpkg.com/@types/tern/-/tern-0.23.9.tgz#6f6093a4a9af3e6bb8dde528e024924d196b367c"
+ integrity sha512-ypzHFE/wBzh+BlH6rrBgS5I/Z7RD21pGhZ2rltb/+ZrVM1awdZwjx7hE5XfuYgHWk9uvV5HLZN3SloevCAp3Bw==
+ dependencies:
+ "@types/estree" "*"
+
"@types/yauzl@^2.9.1":
version "2.10.3"
resolved "https://registry.yarnpkg.com/@types/yauzl/-/yauzl-2.10.3.tgz#e9b2808b4f109504a03cda958259876f61017999"
@@ -1833,7 +1852,7 @@ cliui@^8.0.1:
strip-ansi "^6.0.1"
wrap-ansi "^7.0.0"
-codemirror@^5.51.0:
+codemirror@5.65.16, codemirror@^5.51.0:
version "5.65.16"
resolved "https://registry.yarnpkg.com/codemirror/-/codemirror-5.65.16.tgz#efc0661be6bf4988a6a1c2fe6893294638cdb334"
integrity sha512-br21LjYmSlVL0vFCPWPfhzUCT34FM/pAdK7rRIZwa0rrtrIdotvP4Oh4GUHsu2E3IrQMCfRkL/fN3ytMNxVQvg==
(jena) 04/06: GH-2767: Use _ for param name to ignore unused arg
Posted by ki...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
kinow pushed a commit to branch GH-2767-fix-js-warnings
in repository https://gitbox.apache.org/repos/asf/jena.git
commit 675d1b9c5042fc3639a89c2acffc3ced91a5e8e2
Author: Bruno P. Kinoshita <ki...@users.noreply.github.com>
AuthorDate: Sat Oct 12 17:02:00 2024 +0200
GH-2767: Use _ for param name to ignore unused arg
---
.../jena-fuseki-ui/src/mixins/current-dataset-navigation-guards.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/jena-fuseki2/jena-fuseki-ui/src/mixins/current-dataset-navigation-guards.js b/jena-fuseki2/jena-fuseki-ui/src/mixins/current-dataset-navigation-guards.js
index b79e37ab5f..78a15be39c 100644
--- a/jena-fuseki2/jena-fuseki-ui/src/mixins/current-dataset-navigation-guards.js
+++ b/jena-fuseki2/jena-fuseki-ui/src/mixins/current-dataset-navigation-guards.js
@@ -31,7 +31,7 @@ export default {
},
async beforeRouteUpdate (from, to, next) {
// eslint-disable-next-line no-unused-vars
- next(async vm => {
+ next(async _ => {
await this.loadCurrentDataset()
})
},
(jena) 02/06: GH-2767: Fix jsdoc type
Posted by ki...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
kinow pushed a commit to branch GH-2767-fix-js-warnings
in repository https://gitbox.apache.org/repos/asf/jena.git
commit 736e77c2ec5080cd0e672b701d012d7227e04945
Author: Bruno P. Kinoshita <ki...@users.noreply.github.com>
AuthorDate: Sat Oct 12 17:00:53 2024 +0200
GH-2767: Fix jsdoc type
---
jena-fuseki2/jena-fuseki-ui/src/views/Home.vue | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/jena-fuseki2/jena-fuseki-ui/src/views/Home.vue b/jena-fuseki2/jena-fuseki-ui/src/views/Home.vue
index 598ef8aa09..ffcb83b0f9 100644
--- a/jena-fuseki2/jena-fuseki-ui/src/views/Home.vue
+++ b/jena-fuseki2/jena-fuseki-ui/src/views/Home.vue
@@ -124,13 +124,7 @@ export default {
/**
* Fuseki backend response.
*
- * @type {null|{
- * built: string,
- * datasets: [],
- * startDateTime: string,
- * uptime: number,
- * version: string
- * }}
+ * @return {string}
*/
headerString () {
if (!this.serverData) {