You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "hemanthboyina (Jira)" <ji...@apache.org> on 2019/09/06 12:58:00 UTC

[jira] [Commented] (HDFS-14452) Make Op#valueOf() Public

    [ https://issues.apache.org/jira/browse/HDFS-14452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16924227#comment-16924227 ] 

hemanthboyina commented on HDFS-14452:
--------------------------------------

_other custom implementations that want to store the Op code a different way._

can you specify these [~belugabehr] , so that we can push patch forward .

thanks

> Make Op#valueOf() Public
> ------------------------
>
>                 Key: HDFS-14452
>                 URL: https://issues.apache.org/jira/browse/HDFS-14452
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 3.2.0
>            Reporter: David Mollitor
>            Assignee: hemanthboyina
>            Priority: Minor
>              Labels: noob
>         Attachments: HDFS-14452.patch
>
>
> Change signature of {{private static Op valueOf(byte code)}} to be public.  Right now, the only easy way to look up in Op is to pass in a {{DataInput}} object, which is not all that flexible and efficient for other custom implementations that want to store the Op code a different way.
> https://github.com/apache/hadoop/blob/8c95cb9d6bef369fef6a8364f0c0764eba90e44a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Op.java#L53



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org