You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/06/10 19:21:27 UTC
[GitHub] [incubator-gobblin] codecov-commenter edited a comment on pull request #3027: [GOBBLIN-1187] cancel flow execution when dag manager is disabled
codecov-commenter edited a comment on pull request #3027:
URL: https://github.com/apache/incubator-gobblin/pull/3027#issuecomment-641729270
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3027?src=pr&el=h1) Report
> Merging [#3027](https://codecov.io/gh/apache/incubator-gobblin/pull/3027?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/31f2ef1478c3b5d4887cfc772f0e85057cde1c56&el=desc) will **decrease** coverage by `36.39%`.
> The diff coverage is `4.51%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3027?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3027 +/- ##
============================================
- Coverage 45.66% 9.27% -36.40%
+ Complexity 9296 1695 -7601
============================================
Files 1956 1957 +1
Lines 74397 74564 +167
Branches 8247 8279 +32
============================================
- Hits 33977 6919 -27058
- Misses 37242 66971 +29729
+ Partials 3178 674 -2504
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3027?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/gobblin/runtime/api/SpecExecutor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3027/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9hcGkvU3BlY0V4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...a/org/apache/gobblin/runtime/api/SpecProducer.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3027/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9hcGkvU3BlY1Byb2R1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../apache/gobblin/cluster/GobblinClusterManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3027/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJNYW5hZ2VyLmphdmE=) | `42.79% <ø> (-9.53%)` | `19.00 <0.00> (-4.00)` | |
| [...ache/gobblin/cluster/GobblinHelixJobScheduler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3027/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4Sm9iU2NoZWR1bGVyLmphdmE=) | `17.19% <0.00%> (-21.62%)` | `2.00 <0.00> (-4.00)` | |
| [...pache/gobblin/cluster/JobConfigurationManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3027/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSm9iQ29uZmlndXJhdGlvbk1hbmFnZXIuamF2YQ==) | `65.11% <0.00%> (-22.39%)` | `7.00 <0.00> (-3.00)` | |
| [...blin/cluster/StreamingJobConfigurationManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3027/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU3RyZWFtaW5nSm9iQ29uZmlndXJhdGlvbk1hbmFnZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lin/cluster/event/CancelJobConfigArrivalEvent.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3027/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvZXZlbnQvQ2FuY2VsSm9iQ29uZmlnQXJyaXZhbEV2ZW50LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/gobblin/kafka/writer/Kafka09DataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3027/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMDkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4va2Fma2Evd3JpdGVyL0thZmthMDlEYXRhV3JpdGVyLmphdmE=) | `0.00% <0.00%> (-76.79%)` | `0.00 <0.00> (-9.00)` | |
| [...apache/gobblin/runtime/api/JobCatalogListener.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3027/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkNhdGFsb2dMaXN0ZW5lci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (ø)` | |
| [.../apache/gobblin/runtime/api/MutableJobCatalog.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3027/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL011dGFibGVKb2JDYXRhbG9nLmphdmE=) | `0.00% <0.00%> (-86.67%)` | `0.00 <0.00> (ø)` | |
| ... and [1049 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3027/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3027?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3027?src=pr&el=footer). Last update [31f2ef1...64537f3](https://codecov.io/gh/apache/incubator-gobblin/pull/3027?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org