You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/01 13:16:38 UTC

[GitHub] [skywalking-cli] fgksgf opened a new pull request #93: Refactor project to use goapi

fgksgf opened a new pull request #93:
URL: https://github.com/apache/skywalking-cli/pull/93


   - [ ] Remove git submodules
   - [ ] Remove gen codes and graphql api
   - [ ] Update makefile and readme


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-cli] kezhenxu94 commented on pull request #93: Refactor project to use goapi

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #93:
URL: https://github.com/apache/skywalking-cli/pull/93#issuecomment-811904955


   CI failed, codes LGTM, thanks for the quick reaction!! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-cli] kezhenxu94 commented on pull request #93: Refactor project to use goapi

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #93:
URL: https://github.com/apache/skywalking-cli/pull/93#issuecomment-812274343


   > > CI failed, codes LGTM, thanks for the quick reaction!!
   > 
   > The project looks much compact. BTW, does goapi need release ?
   
   It would be nice if goapi can be released so that we have clear change logs between releases, though it's not a must.
   
   @hanahmily FYI this PR is merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-cli] fgksgf merged pull request #93: Refactor project to use goapi

Posted by GitBox <gi...@apache.org>.
fgksgf merged pull request #93:
URL: https://github.com/apache/skywalking-cli/pull/93


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-cli] fgksgf commented on pull request #93: Refactor project to use goapi

Posted by GitBox <gi...@apache.org>.
fgksgf commented on pull request #93:
URL: https://github.com/apache/skywalking-cli/pull/93#issuecomment-811928797


   > CI failed, codes LGTM, thanks for the quick reaction!!
   
   The project looks much compact. BTW, does goapi need release ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org