You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@fluo.apache.org by Arvind Shyamsundar <ar...@microsoft.com.INVALID> on 2020/10/05 22:04:46 UTC
RE: [EXTERNAL] PRs for .asf.yaml / Hacktoberfest
Hi Christopher - Thank you for putting these together. Some notes:
- I presume we will need to remove the labels after the Hacktoberfest event concludes?
- For the PR on Fluo-Recipes, I logged an issue to investigate why CI failing (looks like that has been failing for a while).
Thanks,
Arvind Shyamsundar
-----Original Message-----
From: Christopher <ct...@apache.org>
Sent: Monday, October 5, 2020 1:16 PM
To: fluo-dev <de...@fluo.apache.org>
Subject: [EXTERNAL] PRs for .asf.yaml / Hacktoberfest
Hi,
Here's some PRs for adding .asf.yaml to each of our repos, listed below for quick reference/convenience:
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Ffluo%2Fpull%2F1103&data=02%7C01%7Carvindsh%40microsoft.com%7C0e649cbbdf194c147ff508d8696b8864%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637375257856834678&sdata=ISMRYDcRZTAVKSWFSnnBEn5UbBoj21O5gHjjeM7I7pw%3D&reserved=0
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Ffluo-bytes%2Fpull%2F8&data=02%7C01%7Carvindsh%40microsoft.com%7C0e649cbbdf194c147ff508d8696b8864%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637375257856834678&sdata=MmnhglqDzLj3MExBluoE%2FWpqzNBHqnvp1hgCkYvRqgo%3D&reserved=0
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Ffluo-docker%2Fpull%2F17&data=02%7C01%7Carvindsh%40microsoft.com%7C0e649cbbdf194c147ff508d8696b8864%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637375257856834678&sdata=jVC6%2Bzwj0s%2FJORsLELbfb8sHkPzwjWkuz2pTKhjHFDY%3D&reserved=0
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Ffluo-examples%2Fpull%2F13&data=02%7C01%7Carvindsh%40microsoft.com%7C0e649cbbdf194c147ff508d8696b8864%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637375257856834678&sdata=0NAOgoMgdl42iUfQUQlQ03C6Tgkzmo8f0FZD4PEMcBc%3D&reserved=0
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Ffluo-muchos%2Fpull%2F375&data=02%7C01%7Carvindsh%40microsoft.com%7C0e649cbbdf194c147ff508d8696b8864%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637375257856834678&sdata=oGuyG25uIy9milJup5vHzFpdTo3CO4NUDIN6%2ByV0Ysk%3D&reserved=0
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Ffluo-recipes%2Fpull%2F152&data=02%7C01%7Carvindsh%40microsoft.com%7C0e649cbbdf194c147ff508d8696b8864%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637375257856834678&sdata=yfwgWGjAG6SwuYH9QGoE0BH29Q%2B4uHprCtFR9hwq6n4%3D&reserved=0
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Ffluo-uno%2Fpull%2F258&data=02%7C01%7Carvindsh%40microsoft.com%7C0e649cbbdf194c147ff508d8696b8864%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637375257856834678&sdata=vb3lbu42MfEQUErVBBc%2FloIUck151SoCGnardIBfPSA%3D&reserved=0
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Ffluo-website%2Fpull%2F199&data=02%7C01%7Carvindsh%40microsoft.com%7C0e649cbbdf194c147ff508d8696b8864%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637375257856834678&sdata=dTaAuExXsIO%2BUJMIsZ84wouUPzi8Ctrl%2Fjk3FUUVl18%3D&reserved=0
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Ffluo-yarn%2Fpull%2F21&data=02%7C01%7Carvindsh%40microsoft.com%7C0e649cbbdf194c147ff508d8696b8864%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637375257856834678&sdata=Kt8yRmpBgyssZpngEyqEOZgWqiLYToe%2Bab1CqZQATck%3D&reserved=0
Please review quickly, as the topics on our repos need to include "hacktoberfest" for PRs against our repos to count for contributors participating in GitHub/DigitalOcean's annual Hacktoberfest event, which is good for the community.
Thanks,
Christopher
Re: [EXTERNAL] PRs for .asf.yaml / Hacktoberfest
Posted by Christopher <ct...@apache.org>.
On Mon, Oct 5, 2020 at 6:05 PM Arvind Shyamsundar
<ar...@microsoft.com.invalid> wrote:
>
> Hi Christopher - Thank you for putting these together. Some notes:
>
Not a problem. Thanks for reviewing them so quickly. Updating the
labels sooner means that new contributors can find our repos sooner,
and will ensures the contributors receive credit for any PRs they make
as part of the event (if they are participating). I considered pushing
the changes without a code review (against our established norms), and
offering an explanation on the dev list, since it was time-sensitive,
but since you reviewed so quickly, that wasn't necessary. :)
> - I presume we will need to remove the labels after the Hacktoberfest event concludes?
No. We can leave them up. They will likely be useful again next year,
and there's no harm leaving them up in the interim. In fact, it may
make our repos easier to find when somebody is searching the
Hacktoberfest website, even if the event is over.
> - For the PR on Fluo-Recipes, I logged an issue to investigate why CI failing (looks like that has been failing for a while).
Thanks.