[GitHub] [ignite] Mmuzaf commented on a change in pull request #7959: IGNITE-13155: Fix NullPointerException on in-memory cluster for snapshot creation

[GitBox <gi...@apache.org>]

Mmuzaf commented on a change in pull request #7959:
URL: https://github.com/apache/ignite/pull/7959#discussion_r444355630



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteSnapshotManager.java
##########
@@ -735,6 +738,9 @@ public void cancelLocalSnapshotTask(String name) {
             if (!IgniteFeatures.allNodesSupports(cctx.discovery().aliveServerNodes(), PERSISTENCE_CACHE_SNAPSHOT))
                 throw new IgniteException("Not all nodes in the cluster support a snapshot operation.");
 
+            if (!CU.isPersistenceEnabled(cctx.gridConfig()))
+                throw new IgniteException("Create snapshot request has been rejected. Snapshots on an in-memory clusters are not allowed.");

Review comment:
       Fixed.

##########
File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/AbstractSnapshotSelfTest.java
##########
@@ -132,14 +135,15 @@ public void beforeTestSnapshot() throws Exception {
         cleanPersistenceDir();
 
         dfltCacheCfg = txCacheConfig(new CacheConfiguration<>(DEFAULT_CACHE_NAME));
+        persistence = true;

Review comment:
       Fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org