You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/08 21:59:19 UTC
[GitHub] [spark] xinrong-databricks opened a new pull request #33274: [SPARK-36001][PYTHON] Assume result's index to be disordered in tests with operations on different Series
xinrong-databricks opened a new pull request #33274:
URL: https://github.com/apache/spark/pull/33274
### What changes were proposed in this pull request?
For tests with operations on different Series, sort index of results before comparing them with pandas.
### Why are the changes needed?
We have many tests with operations on different Series in `spark/python/pyspark/pandas/tests/data_type_ops/` that assume the result's index to be sorted and then compare to the pandas' behavior. The assumption is wrong, so we should sort index of such results before comparing them with pandas.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33274: [SPARK-36001][PYTHON] Assume result's index to be disordered in tests with operations on different Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33274:
URL: https://github.com/apache/spark/pull/33274#issuecomment-876870421
**[Test build #140830 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140830/testReport)** for PR 33274 at commit [`66a5492`](https://github.com/apache/spark/commit/66a5492f23434b4f5f90729a94caf70fa615644f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33274: [SPARK-36001][PYTHON] Assume result's index to be disordered in tests with operations on different Series
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33274:
URL: https://github.com/apache/spark/pull/33274#issuecomment-876879027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33274: [SPARK-36001][PYTHON] Assume result's index to be disordered in tests with operations on different Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33274:
URL: https://github.com/apache/spark/pull/33274#issuecomment-876811607
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45335/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33274: [SPARK-36001][PYTHON] Assume result's index to be disordered in tests with operations on different Series
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33274:
URL: https://github.com/apache/spark/pull/33274#issuecomment-876862233
**[Test build #140830 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140830/testReport)** for PR 33274 at commit [`66a5492`](https://github.com/apache/spark/commit/66a5492f23434b4f5f90729a94caf70fa615644f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33274: [SPARK-36001][PYTHON] Assume result's index to be disordered in tests with operations on different Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33274:
URL: https://github.com/apache/spark/pull/33274#issuecomment-876788519
**[Test build #140821 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140821/testReport)** for PR 33274 at commit [`e1d5a4e`](https://github.com/apache/spark/commit/e1d5a4e34c44292a53955f37f475a7c226e5b180).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #33274: [SPARK-36001][PYTHON] Assume result's index to be disordered in tests with operations on different Series
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #33274:
URL: https://github.com/apache/spark/pull/33274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33274: [SPARK-36001][PYTHON] Assume result's index to be disordered in tests with operations on different Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33274:
URL: https://github.com/apache/spark/pull/33274#issuecomment-876862233
**[Test build #140830 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140830/testReport)** for PR 33274 at commit [`66a5492`](https://github.com/apache/spark/commit/66a5492f23434b4f5f90729a94caf70fa615644f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33274: [SPARK-36001][PYTHON] Assume result's index to be disordered in tests with operations on different Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33274:
URL: https://github.com/apache/spark/pull/33274#issuecomment-876799361
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45335/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33274: [SPARK-36001][PYTHON] Assume result's index to be disordered in tests with operations on different Series
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33274:
URL: https://github.com/apache/spark/pull/33274#issuecomment-876777236
**[Test build #140821 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140821/testReport)** for PR 33274 at commit [`e1d5a4e`](https://github.com/apache/spark/commit/e1d5a4e34c44292a53955f37f475a7c226e5b180).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33274: [SPARK-36001][PYTHON] Assume result's index to be disordered in tests with operations on different Series
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33274:
URL: https://github.com/apache/spark/pull/33274#issuecomment-876779075
**[Test build #140824 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140824/testReport)** for PR 33274 at commit [`e4e309d`](https://github.com/apache/spark/commit/e4e309dfc17151f4d1b73662507173ac7f155ebf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33274: [SPARK-36001][PYTHON] Assume result's index to be disordered in tests with operations on different Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33274:
URL: https://github.com/apache/spark/pull/33274#issuecomment-876777236
**[Test build #140821 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140821/testReport)** for PR 33274 at commit [`e1d5a4e`](https://github.com/apache/spark/commit/e1d5a4e34c44292a53955f37f475a7c226e5b180).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33274: [SPARK-36001][PYTHON] Assume result's index to be disordered in tests with operations on different Series
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33274:
URL: https://github.com/apache/spark/pull/33274#issuecomment-876799609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33274: [SPARK-36001][PYTHON] Assume result's index to be disordered in tests with operations on different Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33274:
URL: https://github.com/apache/spark/pull/33274#issuecomment-876779075
**[Test build #140824 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140824/testReport)** for PR 33274 at commit [`e4e309d`](https://github.com/apache/spark/commit/e4e309dfc17151f4d1b73662507173ac7f155ebf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33274: [SPARK-36001][PYTHON] Assume result's index to be disordered in tests with operations on different Series
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33274:
URL: https://github.com/apache/spark/pull/33274#issuecomment-876889888
Merged to master and branch-3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33274: [SPARK-36001][PYTHON] Assume result's index to be disordered in tests with operations on different Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33274:
URL: https://github.com/apache/spark/pull/33274#issuecomment-876794012
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45332/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33274: [SPARK-36001][PYTHON] Assume result's index to be disordered in tests with operations on different Series
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33274:
URL: https://github.com/apache/spark/pull/33274#issuecomment-876799607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33274: [SPARK-36001][PYTHON] Assume result's index to be disordered in tests with operations on different Series
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33274:
URL: https://github.com/apache/spark/pull/33274#issuecomment-876879028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on pull request #33274: [SPARK-36001][PYTHON] Assume result's index to be disordered in tests with operations on different Series
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on pull request #33274:
URL: https://github.com/apache/spark/pull/33274#issuecomment-876861877
`ERROR [5.003s]: test_await_termination_or_timeout (pyspark.streaming.tests.test_context.StreamingContextTests)`
Retriggered tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33274: [SPARK-36001][PYTHON] Assume result's index to be disordered in tests with operations on different Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33274:
URL: https://github.com/apache/spark/pull/33274#issuecomment-876874831
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45341/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on pull request #33274: [SPARK-36001][PYTHON] Assume result's index to be disordered in tests with operations on different Series
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on pull request #33274:
URL: https://github.com/apache/spark/pull/33274#issuecomment-876778653
CC @ueshin @HyukjinKwon @itholic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33274: [SPARK-36001][PYTHON] Assume result's index to be disordered in tests with operations on different Series
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33274:
URL: https://github.com/apache/spark/pull/33274#issuecomment-876790589
**[Test build #140824 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140824/testReport)** for PR 33274 at commit [`e4e309d`](https://github.com/apache/spark/commit/e4e309dfc17151f4d1b73662507173ac7f155ebf).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33274: [SPARK-36001][PYTHON] Assume result's index to be disordered in tests with operations on different Series
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33274:
URL: https://github.com/apache/spark/pull/33274#issuecomment-876819994
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45335/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33274: [SPARK-36001][PYTHON] Assume result's index to be disordered in tests with operations on different Series
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33274:
URL: https://github.com/apache/spark/pull/33274#issuecomment-876819994
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45335/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org