[jira] [Commented] (CASSANDRA-15582) 4.0 quality testing: metrics

["Stephen Mallette (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-15582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072999#comment-17072999 ] 

Stephen Mallette commented on CASSANDRA-15582:
----------------------------------------------

Here is a first contribution on this issue:

https://github.com/apache/cassandra/compare/trunk...spmallette:CASSANDRA-15582-trunk-batchmetrics

It improves the {{BatchMetricsTest}} as I alluded to above. All three metrics are now covered instead of just two and I've modified the test to validate random ranges of batch sizes, partitions, and statement counts. On failure it will print the seed for the random as part of the failure method to ensure that the failing condition can be recreated. Happy to hear any feedback reviewers might have.

> 4.0 quality testing: metrics
> ----------------------------
>
>                 Key: CASSANDRA-15582
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15582
>             Project: Cassandra
>          Issue Type: Task
>          Components: Test/dtest
>            Reporter: Josh McKenzie
>            Assignee: Romain Hardouin
>            Priority: Normal
>             Fix For: 4.0-rc
>
>
> In past releases we've unknowingly broken metrics integrations and introduced performance regressions in metrics collection and reporting. We strive in 4.0 to not do that. Metrics should work well!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org