You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2013/07/24 14:45:48 UTC
[jira] [Commented] (WICKET-5284) Too deep recursion in
AbstractHierarchyIterator
[ https://issues.apache.org/jira/browse/WICKET-5284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718325#comment-13718325 ]
Martin Grigorov commented on WICKET-5284:
-----------------------------------------
HierarchyIterator classes are kind of experimental.
They were supposed to replace the visitor based component tree traversal but haven't been tested well enough.
Please provide a quickstart app that shows the problem and we will investigate the problem.
In the meantime you can use org.apache.wicket.MarkupContainer#visitChildren(IVisitor<Component, R> visitor) method.
> Too deep recursion in AbstractHierarchyIterator
> -----------------------------------------------
>
> Key: WICKET-5284
> URL: https://issues.apache.org/jira/browse/WICKET-5284
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.9.1
> Reporter: Martin Petricek
>
> In application we have code as follows:
> MarkupContainer mc = ...;
> ComponentHierarchyIterator iter = mc.visitChildren(FormComponent.class);
> for (Component c : iter) {
> ...
> }
> However, when run, on many pages this causes java.lang.StackOverflowError, with lots of the stacktrace filled with lines like this:
> ...
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveUp(AbstractHierarchyIterator.java:302)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveUp(AbstractHierarchyIterator.java:302)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:259)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveDown(AbstractHierarchyIterator.java:170)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:236)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveUp(AbstractHierarchyIterator.java:297)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:259)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveDown(AbstractHierarchyIterator.java:170)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:236)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveDown(AbstractHierarchyIterator.java:170)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:236)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveDown(AbstractHierarchyIterator.java:170)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:236)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveDown(AbstractHierarchyIterator.java:170)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:236)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveUp(AbstractHierarchyIterator.java:297)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveUp(AbstractHierarchyIterator.java:302)
> org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:259)
> ...
> It seems that the search for next component in the iteration produces too deep recursion here (not infinite, but too deep for processing a typical page with relatively lots of components) and I suspect that the length of the stack used by the iterator is proportional to the total number of components in the page.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira