[GitHub] [hudi] rmahindra123 commented on a diff in pull request #9488: [HUDI-6731] BigQuerySyncTool: add flag to allow for read optimized sync for MoR tables

["rmahindra123 (via GitHub)" <gi...@apache.org>]

rmahindra123 commented on code in PR #9488:
URL: https://github.com/apache/hudi/pull/9488#discussion_r1300458207


##########
hudi-gcp/src/main/java/org/apache/hudi/gcp/bigquery/BigQuerySyncConfig.java:
##########
@@ -128,6 +128,12 @@ public class BigQuerySyncConfig extends HoodieSyncConfig implements Serializable
       .withDocumentation("Assume standard yyyy/mm/dd partitioning, this"
           + " exists to support backward compatibility. If you use hoodie 0.3.x, do not set this parameter");
 
+  public static final ConfigProperty<Boolean> BIGQUERY_SYNC_ALLOW_READ_OPTIMIZED_SYNC = ConfigProperty
+      .key("hoodie.gcp.bigquery.sync.allow_read_optimized_sync")
+      .defaultValue(false)

Review Comment:
   yeah i Agree, we should just call it out in the docs. Otherwise lgtm, @codope you can help merge when ready



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org