You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/11/24 01:14:49 UTC

[GitHub] hugoprudente opened a new pull request #4230: [AIRFLOW-3066] Adding support for Parameters on AWS Batch Operator

hugoprudente opened a new pull request #4230: [AIRFLOW-3066] Adding support for Parameters on AWS Batch Operator
URL: https://github.com/apache/incubator-airflow/pull/4230
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-3066) issues and references them in the PR "\[AIRFLOW-3066\] Add job parameters to AWSbatch Operator"
   
   ### Description
   
   - [ ] Added the parameters for using dynamic commands on Job Execution
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   ```
   nosetests -v tests/contrib/operators/test_awsbatch_operator.py
   test_check_success_task_not_raises (tests.contrib.operators.test_awsbatch_operator.TestAWSBatchOperator) ... ok
   test_check_success_tasks_raises (tests.contrib.operators.test_awsbatch_operator.TestAWSBatchOperator) ... ok
   test_check_success_tasks_raises_failed (tests.contrib.operators.test_awsbatch_operator.TestAWSBatchOperator) ... ok
   test_check_success_tasks_raises_multiple (tests.contrib.operators.test_awsbatch_operator.TestAWSBatchOperator) ... ok
   test_check_success_tasks_raises_pending (tests.contrib.operators.test_awsbatch_operator.TestAWSBatchOperator) ... ok
   test_execute_with_failures (tests.contrib.operators.test_awsbatch_operator.TestAWSBatchOperator) ... ok
   test_execute_without_failures (tests.contrib.operators.test_awsbatch_operator.TestAWSBatchOperator) ... ok
   test_init (tests.contrib.operators.test_awsbatch_operator.TestAWSBatchOperator) ... ok
   test_template_fields_overrides (tests.contrib.operators.test_awsbatch_operator.TestAWSBatchOperator) ... ok
   test_wait_end_tasks (tests.contrib.operators.test_awsbatch_operator.TestAWSBatchOperator) ... ok
   
   ----------------------------------------------------------------------
   Ran 10 tests in 0.146s
   
   OK
   [2018-11-24 00:59:23,032] {settings.py:203} DEBUG - Disposing DB connection pool (PID 12221)
   ```
   
   ### Commits
   
   - [ ] My commits all reference Jira issues: [AIRFLOW-3066] Adding support for AWS Batch parameters
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services