[PR] NIFI-15535 - Fixed AWS Connection Pool Shutdown on EKS with STS Credential Refresh [nifi]

["pvillard31 (via GitHub)" <gi...@apache.org>]

pvillard31 opened a new pull request, #11020:
URL: https://github.com/apache/nifi/pull/11020

   # Summary
   
   NIFI-15535 - Fixed AWS Connection Pool Shutdown on EKS with STS Credential Refresh
   
   Fixed `java.lang.IllegalStateException: Connection pool shut down` affecting AWS processors (SQS, S3, etc.) on EKS with pod-level identity. The issue occurs when STS temporary credentials expire and the internal HTTP connection pool used for credential refresh has been garbage collected by the JVM Finalizer thread.
   
   The `AWSCredentialsProviderControllerService` cached a single `AwsCredentialsProvider` instance created during `@OnEnabled`. On EKS, this resolves to a `DefaultCredentialsProvider` whose internal chain creates an `StsClient` with its own `ApacheHttpClient` and `PoolingHttpClientConnectionManager`. The JVM's Finalizer thread can shut down these internal connection pools (confirmed in logs by `[Finalizer] Connection manager is shutting down` entries). While cached STS credentials remain valid (~1h), requests succeed. Once credentials expire, the STS refresh call fails because its HTTP pool was already shut down.
   
   This is a documented AWS SDK V2 behavior: https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/troubleshooting.html#faq-connection-pool-shutdown-exception
   
   The prior fix for NIFI-12836 (commit `02cbe199260`) changed `DefaultCredentialsProvider.create()` to `.builder().build()` to avoid the singleton, but the provider was still cached as a single shared instance in the controller service, leaving it vulnerable to GC finalization of internal SDK objects.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   - [ ] Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `./mvnw clean install -P contrib-check`
     - [ ] JDK 21
     - [ ] JDK 25
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-15535 - Fixed AWS Connection Pool Shutdown on EKS with STS Credential Refresh [nifi]

["turcsanyip (via GitHub)" <gi...@apache.org>]

turcsanyip commented on PR #11020:
URL: https://github.com/apache/nifi/pull/11020#issuecomment-4083631000

   Thanks @pvillard31 for the PR. The fix looks fine on a cursory review. Will check it in more detail and run some tests before merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-15535 - Fixed AWS Connection Pool Shutdown on EKS with STS Credential Refresh [nifi]

["asf-gitbox-commits (via GitHub)" <gi...@apache.org>]

asf-gitbox-commits closed pull request #11020: NIFI-15535 - Fixed AWS Connection Pool Shutdown on EKS with STS Credential Refresh
URL: https://github.com/apache/nifi/pull/11020


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org