You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "jrudolph (via GitHub)" <gi...@apache.org> on 2023/02/22 11:51:52 UTC
[GitHub] [incubator-pekko-http] jrudolph opened a new pull request, #83: update to Scala 2.13.10
jrudolph opened a new pull request, #83:
URL: https://github.com/apache/incubator-pekko-http/pull/83
Recent Scala 2.13 versions deprecated the -target option which then fails the docs module compilation which has warnings as errors.
(Extracted from #81 because it was more complicated than expected)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #83: update to Scala 2.13.10
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #83:
URL: https://github.com/apache/incubator-pekko-http/pull/83#discussion_r1114245385
##########
docs/src/test/scala/docs/http/scaladsl/server/directives/JsonStreamingExamplesSpec.scala:
##########
@@ -125,7 +125,7 @@ class JsonStreamingExamplesSpec extends RoutingSpec with CompileOnlySpec {
Marshalling.WithFixedContentType(ContentTypes.`text/csv(UTF-8)`,
() => {
val txt = t.txt.replaceAll(",", ".")
- val uid = t.uid
+ val uid = t.uid.toString
Review Comment:
This led to a new fatal warning in 2.13.10.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on pull request #83: update to Scala 2.13.10
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #83:
URL: https://github.com/apache/incubator-pekko-http/pull/83#issuecomment-1441458788
We don't really expect behavior changes here, it should be less intrusive than all the package renamings associated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph merged pull request #83: update to Scala 2.13.10
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph merged PR #83:
URL: https://github.com/apache/incubator-pekko-http/pull/83
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #83: update to Scala 2.13.10
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #83:
URL: https://github.com/apache/incubator-pekko-http/pull/83#issuecomment-1441660944
> We don't really expect behavior changes here, it should be less intrusive than all the package renamings associated changes.
👍 Feel free to merge, also since we are also dealing a http server I think this is less of a concern compared to pekko core
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org