You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jackrabbit.apache.org by st...@apache.org on 2010/10/18 16:43:45 UTC
svn commit: r1023820 - in /jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core: nodetype/ state/

Author: stefan
Date: Mon Oct 18 14:43:44 2010
New Revision: 1023820

URL: http://svn.apache.org/viewvc?rev=1023820&view=rev
Log:
JCR-2789: toString() causes StackOverflowError

Modified:
    jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/nodetype/BitSetENTCacheImpl.java
    jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/nodetype/EffectiveNodeTypeCacheImpl.java
    jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/nodetype/NodeTypeManagerImpl.java
    jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/nodetype/NodeTypeRegistry.java
    jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/state/SessionItemStateManager.java
    jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/state/SharedItemStateManager.java

Modified: jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/nodetype/BitSetENTCacheImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/nodetype/BitSetENTCacheImpl.java?rev=1023820&r1=1023819&r2=1023820&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/nodetype/BitSetENTCacheImpl.java (original)
+++ jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/nodetype/BitSetENTCacheImpl.java Mon Oct 18 14:43:44 2010
@@ -224,7 +224,7 @@ public class BitSetENTCacheImpl implemen
      */
     public String toString() {
         StringBuilder builder = new StringBuilder();
-        builder.append("EffectiveNodeTypeCache (" + this + ")\n");
+        builder.append("BitSetENTCacheImpl (" + super.toString() + ")\n");
         builder.append("EffectiveNodeTypes in cache:\n");
         for (Key key : sortedKeys) {
             builder.append(key);

Modified: jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/nodetype/EffectiveNodeTypeCacheImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/nodetype/EffectiveNodeTypeCacheImpl.java?rev=1023820&r1=1023819&r2=1023820&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/nodetype/EffectiveNodeTypeCacheImpl.java (original)
+++ jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/nodetype/EffectiveNodeTypeCacheImpl.java Mon Oct 18 14:43:44 2010
@@ -175,7 +175,7 @@ public class EffectiveNodeTypeCacheImpl 
      */
     public String toString() {
         StringBuilder builder = new StringBuilder();
-        builder.append("EffectiveNodeTypeCache (" + this + ")\n");
+        builder.append("EffectiveNodeTypeCache (" + super.toString() + ")\n");
         builder.append("EffectiveNodeTypes in cache:\n");
         for (Key key : sortedKeys) {
             builder.append(key);

Modified: jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/nodetype/NodeTypeManagerImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/nodetype/NodeTypeManagerImpl.java?rev=1023820&r1=1023819&r2=1023820&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/nodetype/NodeTypeManagerImpl.java (original)
+++ jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/nodetype/NodeTypeManagerImpl.java Mon Oct 18 14:43:44 2010
@@ -623,7 +623,7 @@ public class NodeTypeManagerImpl extends
      *
      * @param definition the definition
      * @return a <code>NodeTypeDef</code>
-     * @throws InvalidNodeTypeDefinitionException if the definiton is invalid
+     * @throws InvalidNodeTypeDefinitionException if the definition is invalid
      * @throws RepositoryException if a repository error occurs
      */
     private QNodeTypeDefinition toNodeTypeDef(NodeTypeDefinition definition)
@@ -637,7 +637,7 @@ public class NodeTypeManagerImpl extends
      * {@inheritDoc}
      */
     public String toString() {
-        return "NodeTypeManager(" + this + ")\n"
+        return "NodeTypeManager(" + super.toString() + ")\n"
             + context.getNodeTypeRegistry();
     }
 

Modified: jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/nodetype/NodeTypeRegistry.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/nodetype/NodeTypeRegistry.java?rev=1023820&r1=1023819&r2=1023820&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/nodetype/NodeTypeRegistry.java (original)
+++ jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/nodetype/NodeTypeRegistry.java Mon Oct 18 14:43:44 2010
@@ -572,7 +572,7 @@ public class NodeTypeRegistry implements
      */
     public String toString() {
         StringBuilder builder = new StringBuilder();
-        builder.append("NodeTypeRegistry (" + this + ")\n");
+        builder.append("NodeTypeRegistry (" + super.toString() + ")\n");
         builder.append("Registered NodeTypes:\n");
         for (QNodeTypeDefinition ntd : registeredNTDefs.values()) {
             builder.append(ntd.getName());

Modified: jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/state/SessionItemStateManager.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/state/SessionItemStateManager.java?rev=1023820&r1=1023819&r2=1023820&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/state/SessionItemStateManager.java (original)
+++ jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/state/SessionItemStateManager.java Mon Oct 18 14:43:44 2010
@@ -124,7 +124,7 @@ public class SessionItemStateManager
      */
     public String toString() {
         StringBuilder builder = new StringBuilder();
-        builder.append("SessionItemStateManager (" + this + ")\n");
+        builder.append("SessionItemStateManager (" + super.toString() + ")\n");
         builder.append("[transient]\n");
         builder.append(transientStore);
         builder.append("[attic]\n");

Modified: jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/state/SharedItemStateManager.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/state/SharedItemStateManager.java?rev=1023820&r1=1023819&r2=1023820&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/state/SharedItemStateManager.java (original)
+++ jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/state/SharedItemStateManager.java Mon Oct 18 14:43:44 2010
@@ -439,7 +439,7 @@ public class SharedItemStateManager
      * {@inheritDoc}
      */
     public String toString() {
-        return "SharedItemStateManager (" + this + ")\n"
+        return "SharedItemStateManager (" + super.toString() + ")\n"
             + "[referenceCache]\n" + cache;
     }