You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by "izumo27 (via GitHub)" <gi...@apache.org> on 2024/01/02 15:36:23 UTC

Re: [PR] [fix][client] Support for PKCS#8 private key [pulsar]

izumo27 commented on PR #21828:
URL: https://github.com/apache/pulsar/pull/21828#issuecomment-1874183131

   > We should keep the original test with `x.pem`key.
   
   In ```testRSAEncryption```, ```producer``` and ```producer2``` use the same key, so it looks like producer2 is not needed.
   https://github.com/apache/pulsar/blob/529e1ab80998143cfe793c018429e9d2bbee5473/pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java#L2780-L2783
   
   Actually, in ECDSA's test, there is only one producer.
   https://github.com/apache/pulsar/blob/529e1ab80998143cfe793c018429e9d2bbee5473/pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java#L2701-L2703


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org