You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by Sephiroth-Lin <gi...@git.apache.org> on 2015/10/13 13:17:16 UTC

[GitHub] spark pull request: [SPARK-9596][SQL]treat hadoop classes as share...

Github user Sephiroth-Lin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7931#discussion_r41853694
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala ---
    @@ -124,6 +124,7 @@ private[hive] class IsolatedClientLoader(
         name.contains("slf4j") ||
         name.contains("log4j") ||
         name.startsWith("org.apache.spark.") ||
    +    (name.startsWith("org.apache.hadoop.") && !name.startsWith("org.apache.hadoop.hive.")) ||
    --- End diff --
    
    scope is too huge, and without reload hadoop, will only have one FileSystem.Cache which will cause [SPARK-11083](https://issues.apache.org/jira/browse/SPARK-11083)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org