You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "orpiske (via GitHub)" <gi...@apache.org> on 2024/03/06 14:32:00 UTC
[PR] CAMEL-20518: replace invalid quote breaking the catalog generation on Windows [camel]
orpiske opened a new pull request, #13394:
URL: https://github.com/apache/camel/pull/13394
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20518: replace invalid quote breaking the catalog generation on Windows [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #13394:
URL: https://github.com/apache/camel/pull/13394#issuecomment-1981111566
Created https://issues.apache.org/jira/browse/CAMEL-20527 based on @davsclaus suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20518: replace invalid quote breaking the catalog generation on Windows [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13394:
URL: https://github.com/apache/camel/pull/13394#issuecomment-1981002533
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20518: replace invalid quote breaking the catalog generation on Windows [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #13394:
URL: https://github.com/apache/camel/pull/13394#issuecomment-1981104841
> Oh nice spotted.
>
> I wonder if the camel-package-maven-plugin can detect this. There is some code that grabs javadoc and "sanitize" the javadoc. Could be that you can search for this char and replace it with the other quote. Or do a WARN if detected or even fail etc.
Thanks!
+1
I think we should implement this sanitization, indeed. I think we could start looking at that after #13343, so not to cause too much rebasing work for that cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-20518: replace invalid quote breaking the catalog generation on Windows [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske merged PR #13394:
URL: https://github.com/apache/camel/pull/13394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org