[GitHub] gordon1992 opened a new issue #13929: commons-codec/io part of `make scalapkg` output JAR

[GitBox <gi...@apache.org>]

gordon1992 opened a new issue #13929: commons-codec/io part of `make scalapkg` output JAR
URL: https://github.com/apache/incubator-mxnet/issues/13929
 
 
   This is related #13528 (which is referring to the inclusion of the Scala standard library).
   
   The JAR output by `make scalapkg` (say mxnet-full_2.11-INTERNAL.jar) contains commons-codec (1.10) and commons-io (2.1).
   
   This is causing classpath issues when depending on MXNet and commons-io directly.
   
   In my specific case I depend on commons-io 2.5 but the commons-io 2.1 bundled by MXNet is shadowing my own dependency on 2.5.
   
   I have a commit in my fork which excludes commons-codec and commons-io from the assembly https://github.com/gordon1992/incubator-mxnet/commit/0b141f7663eb20c0b6a73bdd46c309257d7d9e85 but I would like to assist in fixing the problem directly.
   
   I see two options:
   1) Explicitly exclude commons-codec and commons-io from the assembly. The MXNet library then needs to add commons-codec and commons-io as a [transitive dependency](https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Transitive_Dependencies).
   2. Shadow the commons-codec and commons-io library using Maven Shade Plugin: https://maven.apache.org/plugins/maven-shade-plugin/
   
   My current knowledge of Maven is sufficiently shallow that I would appreciate input from maintainers regarding the most appropriate fix for the project and making the fix more general (removal of Scala standard library, SLF4j and any other 3rd party libraries currently bundled).
   
   Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services