You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/15 15:32:00 UTC

[GitHub] [flink] zentol opened a new pull request #12180: [FLINK-17163][docker] Remove flink-contrib/docker-flink

zentol opened a new pull request #12180:
URL: https://github.com/apache/flink/pull/12180


   Roughly based on #12172.
   
   Removes flink-container/[docker|kubernetes] and flink-contrib/docker-flink in favor of the newly established flink-docker repository.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12180: [FLINK-17163][docker] Remove flink-contrib/docker-flink

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12180:
URL: https://github.com/apache/flink/pull/12180#issuecomment-629325553


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "edb60e158ad5b3f4bb15a896c869beeee2ac2e85",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "edb60e158ad5b3f4bb15a896c869beeee2ac2e85",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * edb60e158ad5b3f4bb15a896c869beeee2ac2e85 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12180: [FLINK-17163][docker] Remove flink-contrib/docker-flink

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12180:
URL: https://github.com/apache/flink/pull/12180#issuecomment-629325553


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "edb60e158ad5b3f4bb15a896c869beeee2ac2e85",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1459",
       "triggerID" : "edb60e158ad5b3f4bb15a896c869beeee2ac2e85",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * edb60e158ad5b3f4bb15a896c869beeee2ac2e85 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1459) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12180: [FLINK-17163][docker] Remove flink-contrib/docker-flink

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12180:
URL: https://github.com/apache/flink/pull/12180#issuecomment-629325553


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "edb60e158ad5b3f4bb15a896c869beeee2ac2e85",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1459",
       "triggerID" : "edb60e158ad5b3f4bb15a896c869beeee2ac2e85",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * edb60e158ad5b3f4bb15a896c869beeee2ac2e85 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1459) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12180: [FLINK-17163][docker] Remove flink-contrib/docker-flink

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #12180:
URL: https://github.com/apache/flink/pull/12180#issuecomment-629317319

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit edb60e158ad5b3f4bb15a896c869beeee2ac2e85 (Fri May 15 15:36:06 UTC 2020)

**Warnings:**
* Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] azagrebin edited a comment on pull request #12180: [FLINK-17163][docker] Remove flink-contrib/docker-flink

Posted by GitBox <gi...@apache.org>.

azagrebin edited a comment on pull request #12180:
URL: https://github.com/apache/flink/pull/12180#issuecomment-629417278


   @tillrohrmann 
   #12131 is merged and it removes the references to `flink-container/docker` and `flink-container/kubernetes` from the `docker.md` and `kubernetes.md`.
   
   @zentol 
   [FLINK-17740](https://issues.apache.org/jira/browse/FLINK-17740) is created for removal of `flink-container/kubernetes`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on pull request #12180: [FLINK-17163][docker] Remove flink-contrib/docker-flink

Posted by GitBox <gi...@apache.org>.

tillrohrmann commented on pull request #12180:
URL: https://github.com/apache/flink/pull/12180#issuecomment-629639754


   Just a note: The `Kubernetes test` e2e test failed in the latest build of this PR. I assume this is related to the PR #12172.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] azagrebin commented on pull request #12180: [FLINK-17163][docker] Remove flink-contrib/docker-flink

Posted by GitBox <gi...@apache.org>.

azagrebin commented on pull request #12180:
URL: https://github.com/apache/flink/pull/12180#issuecomment-629417278


   @tillrohrmann 
   #12131 is merged and it removes the references to `flink-container/docker` and `flink-container/kubernetes` from the `docker.md` and `kubernetes.md`.
   [FLINK-17740](https://issues.apache.org/jira/browse/FLINK-17740) is created for removal of `flink-container/kubernetes`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on pull request #12180: [FLINK-17163][docker] Remove flink-contrib/docker-flink

Posted by GitBox <gi...@apache.org>.

tillrohrmann commented on pull request #12180:
URL: https://github.com/apache/flink/pull/12180#issuecomment-629639447


   Great, thanks @azagrebin.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #12180: [FLINK-17163][docker] Remove flink-contrib/docker-flink

Posted by GitBox <gi...@apache.org>.

zentol merged pull request #12180:
URL: https://github.com/apache/flink/pull/12180


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12180: [FLINK-17163][docker] Remove flink-contrib/docker-flink

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #12180:
URL: https://github.com/apache/flink/pull/12180#issuecomment-629317319

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit a1f45773f01d658c7603be1ffccb58b0cdd9095d (Fri Oct 16 10:35:21 UTC 2020)

**Warnings:**
* Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

For queries about this service, please contact Infrastructure at:
users@infra.apache.org