You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/12/05 09:35:42 UTC

[GitHub] codecov-io commented on issue #506: SCB-1053 Allow instances to be nil

codecov-io commented on issue #506: SCB-1053 Allow instances to be nil
URL: https://github.com/apache/servicecomb-service-center/pull/506#issuecomment-444420306
 
 
   # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/506?src=pr&el=h1) Report
   > Merging [#506](https://codecov.io/gh/apache/servicecomb-service-center/pull/506?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/a0f5e64ef6112f69b68037c8877c6149f37cc18b?src=pr&el=desc) will **decrease** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/506/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/506?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #506      +/-   ##
   ==========================================
   - Coverage   59.35%   59.33%   -0.03%     
   ==========================================
     Files         166      166              
     Lines       13944    13944              
   ==========================================
   - Hits         8277     8274       -3     
     Misses       5081     5081              
   - Partials      586      589       +3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/506?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [server/govern/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/506/diff?src=pr&el=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `72.6% <0%> (-0.34%)` | :arrow_down: |
   | [server/plugin/pkg/registry/etcd/etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/506/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9ldGNkLmdv) | `86.17% <0%> (-0.19%)` | :arrow_down: |
   | [server/broker/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/506/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv) | `57.78% <0%> (-0.16%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/506?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/506?src=pr&el=footer). Last update [a0f5e64...cc8ad54](https://codecov.io/gh/apache/servicecomb-service-center/pull/506?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services