You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/31 08:58:52 UTC
[GitHub] [spark] MaxGekk opened a new pull request, #37740: [MINOR][SQL] Remove unused `checkForNumericExpr()`
MaxGekk opened a new pull request, #37740:
URL: https://github.com/apache/spark/pull/37740
### What changes were proposed in this pull request?
In the PR, I propose to remove 2 unused methods: `checkForNumericExpr()` and `checkTypesInternal()`. Type checks of inputs in `Pmod` are performed by `BinaryArithmetic.checkInputDataTypes()`.
### Why are the changes needed?
To improve code maintenance.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
By running the related test suites:
```
$ build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite"
$ build/sbt "test:testOnly *ArithmeticExpressionSuite"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #37740: [MINOR][SQL] Remove unused `checkForNumericExpr()`
Posted by GitBox <gi...@apache.org>.
wangyum commented on PR #37740:
URL: https://github.com/apache/spark/pull/37740#issuecomment-1232812649
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum closed pull request #37740: [MINOR][SQL] Remove unused `checkForNumericExpr()`
Posted by GitBox <gi...@apache.org>.
wangyum closed pull request #37740: [MINOR][SQL] Remove unused `checkForNumericExpr()`
URL: https://github.com/apache/spark/pull/37740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org