You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "linhr (via GitHub)" <gi...@apache.org> on 2025/12/11 13:37:04 UTC
[PR] fix: Fix a few minor issues with join metrics [datafusion]
linhr opened a new pull request, #19283:
URL: https://github.com/apache/datafusion/pull/19283
## Which issue does this PR close?
N/A
## Rationale for this change
There are a few minor issues for join metrics:
1. The `ExecutionPlan::metrics()` method is missing for `PiecewiseMergeJoinExec`.
2. The metric names for left and right inputs are the same in `StreamJoinMetrics`, so the user cannot distinguish the metrics in the metric set.
## What changes are included in this PR?
This PR fixes the issues above.
## Are these changes tested?
N/A
## Are there any user-facing changes?
The changes to metric names in `StreamJoinMetrics` (used by `SymmetricHashJoinExec`) is potentially user-facing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Fix a few minor issues with join metrics [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #19283:
URL: https://github.com/apache/datafusion/pull/19283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Fix a few minor issues with join metrics [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #19283:
URL: https://github.com/apache/datafusion/pull/19283#issuecomment-3650729143
Thanks @linhr and @xudong963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org