You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/10/22 17:28:05 UTC
[PR] Handle mixed akka/pekko protocol names [incubator-pekko]
mdedetrich opened a new pull request, #765:
URL: https://github.com/apache/incubator-pekko/pull/765
Resolves: https://github.com/apache/incubator-pekko/issues/108
Currently in draft
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #765:
URL: https://github.com/apache/incubator-pekko/pull/765#issuecomment-1906933410
I want to see this in 1.1.0-M1. It makes it easier for people to try it out. M1 is also a release that we can caveat. A 1.0.3 release would be expected to have well tested, working code. This change still feels experimental but worth experimenting with nonetheless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #765:
URL: https://github.com/apache/incubator-pekko/pull/765#issuecomment-1806821986
> I disagree about having this as a v1.0.x only feature. We've already had users who have tried to switch to Pekko from a version of Akka newer than v2.6. In the real world, we will have Akka users who reach the size where they need to pay license fees. If we add this feature, there is no reason not to keep it for a while. And if we then agree that it is useful to support this for a while (maybe 2 years as an example) then that makes it tidier to develop this on main branch - especially since we can release milestone versions.
I'm not disagreeing about it being in both versions, I am just saying that it has to land in 1.0.x as agreed upon and if it's going in 1.1.x as well then it makes sense for the feature to be complete and tested before the 1.1.0 full release otherwise we will have feature gaps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #765:
URL: https://github.com/apache/incubator-pekko/pull/765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #765:
URL: https://github.com/apache/incubator-pekko/pull/765#issuecomment-1774171561
There is also https://github.com/apache/incubator-pekko/blob/00c6bac1a70d2e0dc0408a4699d136d599855462/remote/src/main/scala/org/apache/pekko/remote/transport/PekkoProtocolTransport.scala#L76
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #765:
URL: https://github.com/apache/incubator-pekko/pull/765#issuecomment-1805642160
> @mdedetrich what would you think of merging this soon more or less as is but we document it as experimental. Then we can release v1.0.2 with this and see if we can crowdsource the testing. Alternatively, we add it to main only, for now and release v1.1.0-M1 and again see if we can get people to test with it.
Not really confident merging this as is because @He-Pin said that the issue is more complicated and we also need to do port roll-over to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #765:
URL: https://github.com/apache/incubator-pekko/pull/765#issuecomment-1805638142
@mdedetrich what would you think of merging this soon more or less as is but we document it as experimental. Then we can release v1.0.2 with this and see if we can crowdsource the testing. Alternatively, we add it to main only, for now and release v1.1.0-M1 and again see if we can get people to test with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #765:
URL: https://github.com/apache/incubator-pekko/pull/765#issuecomment-1805848160
> I think this PR is bettered targeted at main branch. We can backport it when we have something that we are confident in. We can merge experimental or partial impls to main.
@He-Pin Brought up an interesting point in that this may only be needed in 1.0.x because there is a presumption that once you migrate from an Akka cluster to a Pekko one running 1.0.x, there is no reason that the feature would be needed in 1.1.x (even though we are technically "breaking users").
Given this and the fact that there is a community agreement that all migration (from Akka) related features should land in Pekko 1.0.x I think leaving this to target 1.0.x is the right decision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #765:
URL: https://github.com/apache/incubator-pekko/pull/765#discussion_r1368917129
##########
remote/src/main/resources/reference.conf:
##########
@@ -184,6 +184,20 @@ pekko {
# is 'off'. Set this to 'off' to suppress these.
warn-unsafe-watch-outside-cluster = on
+ # When receiving requests from other remote actors, what are the valid
+ # prefix's to check against. Useful for when dealing with rolling cluster
+ # migrations with compatible systems such as Lightbend's Akka.
+ accept-protocol-names = ["pekko", "akka"]
Review Comment:
It's a matter of style not controversy, all good I'll find an example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #765:
URL: https://github.com/apache/incubator-pekko/pull/765#issuecomment-1911890151
> @mdedetrich noone seems to object to a 1.0.3-M1. Can we merge this? If we end up with an urgent 1.0.x bug fix issue, we could revert this again - but the likelihood is that the next 1.0.x release will be 1.0.3-M1. It would be nice to have these changes in a snapshot for some pre 1.0.3-M1 testing.
Sure, changed it to review status. It just needs a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #765:
URL: https://github.com/apache/incubator-pekko/pull/765#discussion_r1368913885
##########
remote/src/main/resources/reference.conf:
##########
@@ -184,6 +184,20 @@ pekko {
# is 'off'. Set this to 'off' to suppress these.
warn-unsafe-watch-outside-cluster = on
+ # When receiving requests from other remote actors, what are the valid
+ # prefix's to check against. Useful for when dealing with rolling cluster
+ # migrations with compatible systems such as Lightbend's Akka.
+ accept-protocol-names = ["pekko", "akka"]
Review Comment:
We have comment text in reference.conf files in this repo for things like deprecations (and the version that the deprecation happened in). I thought it would be uncontroversial to have text that says config was only added in v1.0.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #765:
URL: https://github.com/apache/incubator-pekko/pull/765#discussion_r1368950050
##########
remote/src/main/resources/reference.conf:
##########
@@ -184,6 +184,20 @@ pekko {
# is 'off'. Set this to 'off' to suppress these.
warn-unsafe-watch-outside-cluster = on
+ # When receiving requests from other remote actors, what are the valid
+ # prefix's to check against. Useful for when dealing with rolling cluster
+ # migrations with compatible systems such as Lightbend's Akka.
+ accept-protocol-names = ["pekko", "akka"]
Review Comment:
Users look at things like latest scaladocs and latest source code in GitHub and often mistakenly think the support for the features was always there. I would personally -1 any scaladoc for a new function that didn't have `@since`. I do not understand why our configs should not have a similar norm. I don't care what Lightbend used to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #765:
URL: https://github.com/apache/incubator-pekko/pull/765#issuecomment-1911845607
@mdedetrich noone seems to object to a 1.0.3-M1. Can we merge this? If we end up with an urgent 1.0.x bug fix issue, we could revert this again - but the likelihood is that the next 1.0.x release will be 1.0.3-M1. It would be nice to have these changes in a snapshot for some pre 1.0.3-M1 testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #765:
URL: https://github.com/apache/incubator-pekko/pull/765#issuecomment-1806803442
I disagree about having this as a v1.0.x only feature. We've already had users who have tried to switch to Pekko from a version of Akka newer than v2.6. In the real world, we will have Akka users who reach the size where they need to pay license fees. If we add this feature, there is no reason not to keep it for a while. And if we then agree that it is useful to support this for a while (maybe 2 years as an example) then that makes it tidier to develop this on main branch - especially since we can release milestone versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #765:
URL: https://github.com/apache/incubator-pekko/pull/765#discussion_r1368847945
##########
remote/src/main/resources/reference.conf:
##########
@@ -184,6 +184,20 @@ pekko {
# is 'off'. Set this to 'off' to suppress these.
warn-unsafe-watch-outside-cluster = on
+ # When receiving requests from other remote actors, what are the valid
+ # prefix's to check against. Useful for when dealing with rolling cluster
+ # migrations with compatible systems such as Lightbend's Akka.
+ accept-protocol-names = ["pekko", "akka"]
Review Comment:
could we mention that these 2 properties were only added in v1.0.2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #765:
URL: https://github.com/apache/incubator-pekko/pull/765#discussion_r1368934746
##########
remote/src/main/resources/reference.conf:
##########
@@ -184,6 +184,20 @@ pekko {
# is 'off'. Set this to 'off' to suppress these.
warn-unsafe-watch-outside-cluster = on
+ # When receiving requests from other remote actors, what are the valid
+ # prefix's to check against. Useful for when dealing with rolling cluster
+ # migrations with compatible systems such as Lightbend's Akka.
+ accept-protocol-names = ["pekko", "akka"]
Review Comment:
I think it is better to doc this in the reference.conf even if we also document it in the paradox docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #765:
URL: https://github.com/apache/incubator-pekko/pull/765#discussion_r1368930457
##########
remote/src/main/resources/reference.conf:
##########
@@ -184,6 +184,20 @@ pekko {
# is 'off'. Set this to 'off' to suppress these.
warn-unsafe-watch-outside-cluster = on
+ # When receiving requests from other remote actors, what are the valid
+ # prefix's to check against. Useful for when dealing with rolling cluster
+ # migrations with compatible systems such as Lightbend's Akka.
+ accept-protocol-names = ["pekko", "akka"]
Review Comment:
So I just search both `1.` and `2.` in only `*.conf` files and it appears that historically Akka never documents when config values are added, likely because its documented elsewhere (both in actual documentation and migration notes).
Basically the version that a config is added is implicitly derived from the fact that the documentation will refer to it (and if the config isn't there then its not going to be in the documentation).
##########
remote/src/main/resources/reference.conf:
##########
@@ -184,6 +184,20 @@ pekko {
# is 'off'. Set this to 'off' to suppress these.
warn-unsafe-watch-outside-cluster = on
+ # When receiving requests from other remote actors, what are the valid
+ # prefix's to check against. Useful for when dealing with rolling cluster
+ # migrations with compatible systems such as Lightbend's Akka.
+ accept-protocol-names = ["pekko", "akka"]
Review Comment:
So I just searched both `1.` and `2.` in only `*.conf` files and it appears that historically Akka never documents when config values are added, likely because its documented elsewhere (both in actual documentation and migration notes).
Basically the version that a config is added is implicitly derived from the fact that the documentation will refer to it (and if the config isn't there then its not going to be in the documentation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #765:
URL: https://github.com/apache/incubator-pekko/pull/765#discussion_r1368915875
##########
remote/src/main/resources/reference.conf:
##########
@@ -184,6 +184,20 @@ pekko {
# is 'off'. Set this to 'off' to suppress these.
warn-unsafe-watch-outside-cluster = on
+ # When receiving requests from other remote actors, what are the valid
+ # prefix's to check against. Useful for when dealing with rolling cluster
+ # migrations with compatible systems such as Lightbend's Akka.
+ accept-protocol-names = ["pekko", "akka"]
Review Comment:
I would have thought that something like `# This config was added in v1.0.2.` would be ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #765:
URL: https://github.com/apache/incubator-pekko/pull/765#discussion_r1368944963
##########
remote/src/main/resources/reference.conf:
##########
@@ -184,6 +184,20 @@ pekko {
# is 'off'. Set this to 'off' to suppress these.
warn-unsafe-watch-outside-cluster = on
+ # When receiving requests from other remote actors, what are the valid
+ # prefix's to check against. Useful for when dealing with rolling cluster
+ # migrations with compatible systems such as Lightbend's Akka.
+ accept-protocol-names = ["pekko", "akka"]
Review Comment:
Ill have a think about it but I am not seeing the value here given that the config literally won't exist in the docs in earlier versions and if was an issue we would have at least a single example of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #765:
URL: https://github.com/apache/incubator-pekko/pull/765#issuecomment-1775503341
> is the intention to add some `akka` protocol tests in this PR or maybe in a follow up PR?
The intention is to add the tests in the same PR, hence why its a draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #765:
URL: https://github.com/apache/incubator-pekko/pull/765#issuecomment-1774180464
> incubator-pekko/remote/src/main/scala/org/apache/pekko/remote/transport/PekkoProtocolTransport.scala
Thanks pushed, lets see if it breaks anything
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #765:
URL: https://github.com/apache/incubator-pekko/pull/765#discussion_r1368903208
##########
remote/src/main/resources/reference.conf:
##########
@@ -184,6 +184,20 @@ pekko {
# is 'off'. Set this to 'off' to suppress these.
warn-unsafe-watch-outside-cluster = on
+ # When receiving requests from other remote actors, what are the valid
+ # prefix's to check against. Useful for when dealing with rolling cluster
+ # migrations with compatible systems such as Lightbend's Akka.
+ accept-protocol-names = ["pekko", "akka"]
Review Comment:
Do you have an example elsewhere in the docs on the phrasing/formatting of this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #765:
URL: https://github.com/apache/incubator-pekko/pull/765#discussion_r1368930457
##########
remote/src/main/resources/reference.conf:
##########
@@ -184,6 +184,20 @@ pekko {
# is 'off'. Set this to 'off' to suppress these.
warn-unsafe-watch-outside-cluster = on
+ # When receiving requests from other remote actors, what are the valid
+ # prefix's to check against. Useful for when dealing with rolling cluster
+ # migrations with compatible systems such as Lightbend's Akka.
+ accept-protocol-names = ["pekko", "akka"]
Review Comment:
So I just searched both `1.` and `2.` in only `*.conf` files and it appears that historically Akka never documents when config values are added, likely because its documented elsewhere (both in actual `*.md` paradox documentation and migration notes).
Basically the version that a config is added is implicitly derived from the fact that the documentation will refer to it (and if the config isn't there then its not going to be in the documentation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #765:
URL: https://github.com/apache/incubator-pekko/pull/765#issuecomment-1805682813
I think this PR is bettered targeted at main branch. We can backport it when we have something that we are confident in. We can merge experimental or partial impls to main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Handle mixed akka/pekko protocol names [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #765:
URL: https://github.com/apache/incubator-pekko/pull/765#issuecomment-1805676744
Ports are configurable already. For now, mixed cluster users can use Akka port numbers. They can even use Akka ports after the whole cluster is Pekko. We can add support for mixed port numbers later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org