You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2017/10/27 12:33:40 UTC

tinkerpop git commit: TINKERPOP-1812 Bound profile() step assertions to TinkerGraph

Repository: tinkerpop
Updated Branches:
  refs/heads/tp32 0282615ac -> 7d2098187


TINKERPOP-1812 Bound profile() step assertions to TinkerGraph

These assertions can't really be applied to all graph databases equally especially for those graphs that have their own strategies. CTR


Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/7d209818
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/7d209818
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/7d209818

Branch: refs/heads/tp32
Commit: 7d20981872bd0adc769afe86c47f5f3178de7f6e
Parents: 0282615
Author: Stephen Mallette <sp...@genoprime.com>
Authored: Fri Oct 27 08:28:20 2017 -0400
Committer: Stephen Mallette <sp...@genoprime.com>
Committed: Fri Oct 27 08:28:20 2017 -0400

----------------------------------------------------------------------
 .../process/traversal/step/map/ProfileTest.java     | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/7d209818/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ProfileTest.java
----------------------------------------------------------------------
diff --git a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ProfileTest.java b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ProfileTest.java
index 7ac3059..7679f68 100644
--- a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ProfileTest.java
+++ b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ProfileTest.java
@@ -198,8 +198,12 @@ public abstract class ProfileTest extends AbstractGremlinProcessTest {
     public void g_V_sideEffectXThread_sleepX10XX_sideEffectXThread_sleepX5XX_profile() {
         final Traversal<Vertex, TraversalMetrics> traversal = get_g_V_sideEffectXThread_sleepX10XX_sideEffectXThread_sleepX5XX_profile();
         printTraversalForm(traversal);
-        TraversalMetrics traversalMetrics = traversal.next();
-        assertEquals("There should be 8 steps in this traversal (counting injected profile steps).", 8, traversal.asAdmin().getSteps().size());
+
+        // This assertion is really only meant for tinkergraph
+        if (graph.getClass().getSimpleName().equals("TinkerGraph"))
+            assertEquals("There should be 8 steps in this traversal (counting injected profile steps).", 8, traversal.asAdmin().getSteps().size());
+
+        final TraversalMetrics traversalMetrics = traversal.next();
         validate_g_V_sideEffectXThread_sleepX10XX_sideEffectXThread_sleepX5XX_profile(traversalMetrics);
     }
 
@@ -210,8 +214,12 @@ public abstract class ProfileTest extends AbstractGremlinProcessTest {
         final Traversal<Vertex, Vertex> traversal = get_g_V_sideEffectXThread_sleepX10XX_sideEffectXThread_sleepX5XX_profileXmetricsX();
         printTraversalForm(traversal);
         traversal.iterate();
-        assertEquals("There should be 7 steps in this traversal (counting injected profile steps).", 7, traversal.asAdmin().getSteps().size());
-        TraversalMetrics traversalMetrics = traversal.asAdmin().getSideEffects().get(METRICS_KEY);
+
+        // This assertion is really only meant for tinkergraph
+        if (graph.getClass().getSimpleName().equals("TinkerGraph"))
+            assertEquals("There should be 7 steps in this traversal (counting injected profile steps).", 7, traversal.asAdmin().getSteps().size());
+
+        final TraversalMetrics traversalMetrics = traversal.asAdmin().getSideEffects().get(METRICS_KEY);
         validate_g_V_sideEffectXThread_sleepX10XX_sideEffectXThread_sleepX5XX_profile(traversalMetrics);
     }