You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2015/12/05 01:33:43 UTC
Review Request 40999: Fixed flakiness in
ReservationTest.ACLMultipleOperations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40999/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Michael Park.
Bugs: MESOS-4067
https://issues.apache.org/jira/browse/MESOS-4067
Repository: mesos
Description
-------
Fixed flakiness in ReservationTest.ACLMultipleOperations.
Diffs
-----
src/tests/reservation_tests.cpp 3fdf5e121840fe99057e917cca48f1425eff6624
Diff: https://reviews.apache.org/r/40999/diff/
Testing
-------
`GTEST_FILTER="ReservationTest.ACLMultipleOperations" bin/mesos-tests.sh --gtest_repeat=2000 --gtest_break_on_failure`
This test does not fail often unless the `allocation_interval` is reset to a shorter period (5ms, for example). The patch following this one implements this change for all tests in `ReservationTest` to reduce their potential for flakiness (https://reviews.apache.org/r/41000/).
Thanks,
Greg Mann
Re: Review Request 40999: Fixed flakiness in
ReservationTest.ACLMultipleOperations.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Dec. 5, 2015, 12:54 a.m., Joseph Wu wrote:
> > src/tests/reservation_tests.cpp, lines 1663-1664
> > <https://reviews.apache.org/r/40999/diff/1/?file=1154188#file1154188line1663>
> >
> > You can be more explicit in your expectations (about batch allocations) by using `Clock::advance(flags.allocation_interval)`.
> >
> > Using the above will ensure that only one allocation cycle can be triggered.
Great suggestion, thanks Joseph! :-)
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40999/#review109068
-----------------------------------------------------------
On Dec. 8, 2015, 4:57 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40999/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2015, 4:57 p.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-4067
> https://issues.apache.org/jira/browse/MESOS-4067
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed flakiness in ReservationTest.ACLMultipleOperations.
>
>
> Diffs
> -----
>
> src/tests/reservation_tests.cpp eccbb8f8a02b65b26f34e020e736afe0445a6d0d
>
> Diff: https://reviews.apache.org/r/40999/diff/
>
>
> Testing
> -------
>
> `GTEST_FILTER="ReservationTest.ACLMultipleOperations" bin/mesos-tests.sh --gtest_repeat=2000 --gtest_break_on_failure`
>
> To reproduce the original test failure, you may have to set `allocation_interval` to a shorter period (5ms, for example).
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40999: Fixed flakiness in
ReservationTest.ACLMultipleOperations.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40999/#review109068
-----------------------------------------------------------
src/tests/reservation_tests.cpp (lines 1663 - 1664)
<https://reviews.apache.org/r/40999/#comment168490>
You can be more explicit in your expectations (about batch allocations) by using `Clock::advance(flags.allocation_interval)`.
Using the above will ensure that only one allocation cycle can be triggered.
- Joseph Wu
On Dec. 4, 2015, 4:33 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40999/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 4:33 p.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-4067
> https://issues.apache.org/jira/browse/MESOS-4067
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed flakiness in ReservationTest.ACLMultipleOperations.
>
>
> Diffs
> -----
>
> src/tests/reservation_tests.cpp 3fdf5e121840fe99057e917cca48f1425eff6624
>
> Diff: https://reviews.apache.org/r/40999/diff/
>
>
> Testing
> -------
>
> `GTEST_FILTER="ReservationTest.ACLMultipleOperations" bin/mesos-tests.sh --gtest_repeat=2000 --gtest_break_on_failure`
>
> This test does not fail often unless the `allocation_interval` is reset to a shorter period (5ms, for example). The patch following this one implements this change for all tests in `ReservationTest` to reduce their potential for flakiness (https://reviews.apache.org/r/41000/).
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40999: Fixed flakiness in
ReservationTest.ACLMultipleOperations.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40999/#review109457
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Dec. 8, 2015, 4:57 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40999/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2015, 4:57 p.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-4067
> https://issues.apache.org/jira/browse/MESOS-4067
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed flakiness in ReservationTest.ACLMultipleOperations.
>
>
> Diffs
> -----
>
> src/tests/reservation_tests.cpp eccbb8f8a02b65b26f34e020e736afe0445a6d0d
>
> Diff: https://reviews.apache.org/r/40999/diff/
>
>
> Testing
> -------
>
> `GTEST_FILTER="ReservationTest.ACLMultipleOperations" bin/mesos-tests.sh --gtest_repeat=2000 --gtest_break_on_failure`
>
> To reproduce the original test failure, you may have to set `allocation_interval` to a shorter period (5ms, for example).
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40999: Fixed flakiness in
ReservationTest.ACLMultipleOperations.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40999/
-----------------------------------------------------------
(Updated Dec. 8, 2015, 4:57 p.m.)
Review request for mesos, Jie Yu and Michael Park.
Changes
-------
Control clock manually.
Bugs: MESOS-4067
https://issues.apache.org/jira/browse/MESOS-4067
Repository: mesos
Description
-------
Fixed flakiness in ReservationTest.ACLMultipleOperations.
Diffs (updated)
-----
src/tests/reservation_tests.cpp eccbb8f8a02b65b26f34e020e736afe0445a6d0d
Diff: https://reviews.apache.org/r/40999/diff/
Testing (updated)
-------
`GTEST_FILTER="ReservationTest.ACLMultipleOperations" bin/mesos-tests.sh --gtest_repeat=2000 --gtest_break_on_failure`
To reproduce the original test failure, you may have to set `allocation_interval` to a shorter period (5ms, for example).
Thanks,
Greg Mann