You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Trevor Lorimer (JIRA)" <ji...@apache.org> on 2013/09/20 16:43:52 UTC

[jira] [Updated] (HDFS-5216) NumDecomDeadDataNodes not returning correct number of dead decommissioned nodes

     [ https://issues.apache.org/jira/browse/HDFS-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Trevor Lorimer updated HDFS-5216:
---------------------------------

    Attachment: HDFS-5216.diff

Uploaded patch to fix NumDecomDeadDataNodes
                
> NumDecomDeadDataNodes not returning correct number of dead decommissioned nodes 
> --------------------------------------------------------------------------------
>
>                 Key: HDFS-5216
>                 URL: https://issues.apache.org/jira/browse/HDFS-5216
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.1.0-beta
>            Reporter: Trevor Lorimer
>         Attachments: HDFS-5216.diff
>
>
> For HDFS-4860 I essentially copied the process in NamenodejspHelper.generateHealthReport(), so it would be in sync with the original dfsHealth.jsp.
> However looking at this now there may be a bug? in getNumDecomDeadDataNodes(), where:
>     getBlockManager().getDatanodeManager().fetchDatanodes(dead, null, true);
>     
> Where the parameter true indicates that decommissioned nodes should be removed from the list.
> If the flag is true fetchDatanodes calls removeDecomNodeFromList, which will remove a node if an existing datanode does not appear in both include or exclude lists and it has been decommissioned.
> If I am looking to return the Number of Dead Decommissioned Nodes, should I change the remove decommissioned nodes flag to False? i.e.:
>     getBlockManager().getDatanodeManager().fetchDatanodes(null, dead, false);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira