You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by gu...@apache.org on 2017/06/21 20:06:06 UTC
kafka git commit: Revert "MINOR: make flush no-op as we don't need to
call flush on commit."
Repository: kafka
Updated Branches:
refs/heads/trunk 254add953 -> f848e2cd6
Revert "MINOR: make flush no-op as we don't need to call flush on commit."
This reverts commit 90b2a2bf664e4e40d4cd1b46c72732c5edb97cf9.
Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/f848e2cd
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/f848e2cd
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/f848e2cd
Branch: refs/heads/trunk
Commit: f848e2cd681ced74fefdd38a54a44e31e4d867fb
Parents: 254add9
Author: Guozhang Wang <wa...@gmail.com>
Authored: Wed Jun 21 13:05:54 2017 -0700
Committer: Guozhang Wang <wa...@gmail.com>
Committed: Wed Jun 21 13:05:54 2017 -0700
----------------------------------------------------------------------
.../kafka/streams/state/internals/RocksDBStore.java | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kafka/blob/f848e2cd/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
----------------------------------------------------------------------
diff --git a/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java b/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
index cf41c92..a3ecb64 100644
--- a/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
+++ b/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
@@ -95,7 +95,6 @@ public class RocksDBStore<K, V> implements KeyValueStore<K, V> {
private Options options;
private WriteOptions wOptions;
private FlushOptions fOptions;
- private boolean eosEnabled;
protected volatile boolean open = false;
@@ -179,7 +178,7 @@ public class RocksDBStore<K, V> implements KeyValueStore<K, V> {
putInternal(key, value);
}
});
- eosEnabled = checkForEos(context.appConfigs());
+
open = true;
}
@@ -356,12 +355,12 @@ public class RocksDBStore<K, V> implements KeyValueStore<K, V> {
@Override
public synchronized void flush() {
- if (db == null || eosEnabled) {
+ if (db == null) {
return;
}
+ // flush RocksDB
flushInternal();
}
-
/**
* @throws ProcessorStateException if flushing failed because of any internal store exceptions
*/
@@ -373,10 +372,6 @@ public class RocksDBStore<K, V> implements KeyValueStore<K, V> {
}
}
- private boolean checkForEos(Map<String, Object> configs) {
- return StreamsConfig.EXACTLY_ONCE.equals(configs.get(StreamsConfig.PROCESSING_GUARANTEE_CONFIG));
- }
-
@Override
public synchronized void close() {
if (!open) {