[GitHub] graceguo-supercat commented on issue #5418: Retire dashboard v1 (js and python)

[GitBox <gi...@apache.org>]

graceguo-supercat commented on issue #5418: Retire dashboard v1 (js and python)
URL: https://github.com/apache/incubator-superset/pull/5418#issuecomment-406134726
 
 
   i think if user ever saved a `separator` or `markdown` slice before, they should still be able to access by slice_id or etc. Also for geo related viz, we allow user give custom js code as render function. User define their js code in markdown type viz. 
   
   So I didn't delete those viz type, but i added a logic in `Save to dashboard`. if current viz_type is `separator` or `markdown`, the save to dash option is disabled (so that this slice can't be added to dashboard from explore view).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org