You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/03 16:54:49 UTC

[GitHub] [incubator-nuttx] davids5 opened a new pull request #2967: F7 lse static values directly from Kconfig

davids5 opened a new pull request #2967:
URL: https://github.com/apache/incubator-nuttx/pull/2967


   ## Summary
   
   See  https://github.com/apache/incubator-nuttx/pull/2943#issuecomment-789754798 as reported by @juniskane
   ## Impact
   
   This uses the values directly from the Kconfig for the non Auto selection of LSE Drive capability
   
   ## Testing
   
   Build testing.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] davids5 commented on pull request #2967: STM32F7 lse static values directly from Kconfig

Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #2967:
URL: https://github.com/apache/incubator-nuttx/pull/2967#issuecomment-789911088


   > @juniskane for the H7, my approach would be to change the Kconfig. As the version of Silicon changes the Values. This would be a breaking change but the version of silicon is also a breaking change. What are your thoughts?
   
   See https://github.com/apache/incubator-nuttx/pull/2969 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] juniskane commented on pull request #2967: STM32F7 lse static values directly from Kconfig

Posted by GitBox <gi...@apache.org>.
juniskane commented on pull request #2967:
URL: https://github.com/apache/incubator-nuttx/pull/2967#issuecomment-790383842


   This F7 commit looks ok, thanks for fixing this. I commented about H7 separately at #2969


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] davids5 edited a comment on pull request #2967: STM32F7 lse static values directly from Kconfig

Posted by GitBox <gi...@apache.org>.
davids5 edited a comment on pull request #2967:
URL: https://github.com/apache/incubator-nuttx/pull/2967#issuecomment-789880581


   @juniskane for the H7, my approach would be to change the Kconfig. As the version of Silicon changes the Values.  This would be a breaking change but the version of silicon is also a breaking change.  What are your thoughts?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] davids5 commented on pull request #2967: STM32F7 lse static values directly from Kconfig

Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #2967:
URL: https://github.com/apache/incubator-nuttx/pull/2967#issuecomment-789880581


   @juniskane for the H7, my approach would be to change the Kconfig. As the version of Silicon changes the Values.  This would be a breaking change but the version of silicon is also a breaking change.  What are you thoughts?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2967: STM32F7 lse static values directly from Kconfig

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2967:
URL: https://github.com/apache/incubator-nuttx/pull/2967


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org