You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2013/12/19 19:59:05 UTC

Review Request 16393: Group’s local timeout now only expires the ZK session and does not fail operations (master.cpp)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16393/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Bugs: MESOS-883
    https://issues.apache.org/jira/browse/MESOS-883


Repository: mesos-git


Description
-------

Due to error in RB's mesos repo: changes to `src/master/master.cpp` had to be excluded from a previous patch (https://reviews.apache.org/r/16290/) and submitted here.
The ticket for RB repo issue: https://issues.apache.org/jira/browse/INFRA-7115


Diffs
-----

  src/master/master.cpp dd6111946289b82008a66e46df8ef5e538de70ea 

Diff: https://reviews.apache.org/r/16393/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu

Re: Review Request 16393: Group’s local timeout now only expires the ZK session and does not fail operations (master.cpp)

Posted by Ben Mahler <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16393/#review30707
-----------------------------------------------------------



src/master/master.cpp
<https://reviews.apache.org/r/16393/#comment58806>

    No need for this else now that we exit on error.


- Ben Mahler


On Dec. 19, 2013, 6:59 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16393/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2013, 6:59 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-883
>     https://issues.apache.org/jira/browse/MESOS-883
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Due to error in RB's mesos repo: changes to `src/master/master.cpp` had to be excluded from a previous patch (https://reviews.apache.org/r/16290/) and submitted here.
> The ticket for RB repo issue: https://issues.apache.org/jira/browse/INFRA-7115
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp dd6111946289b82008a66e46df8ef5e538de70ea 
> 
> Diff: https://reviews.apache.org/r/16393/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>