[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1482: feat(new_metrics): migrate metrics for some duplication class

["acelyc111 (via GitHub)" <gi...@apache.org>]

acelyc111 commented on code in PR #1482:
URL: https://github.com/apache/incubator-pegasus/pull/1482#discussion_r1198526219


##########
src/replica/duplication/mutation_batch.h:
##########
@@ -45,7 +45,7 @@ class mutation_buffer : public prepare_list
     void commit(decree d, commit_type ct) override;
 
 private:
-    perf_counter_wrapper _counter_dulication_mutation_loss_count;
+    METRIC_VAR_DECLARE_gauge_int64(dup_recent_lost_mutations);

Review Comment:
   Is the "recent" word necesary?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org