You are viewing a plain text version of this content. The canonical link for it is here.
Posted to taglibs-dev@jakarta.apache.org by ba...@apache.org on 2008/11/04 00:34:00 UTC
svn commit: r711123 - in /jakarta/taglibs/proper/standard/trunk/src:
javax/servlet/jsp/jstl/sql/ResultSupport.java
org/apache/taglibs/standard/tag/common/sql/ResultImpl.java
Author: bayard
Date: Mon Nov 3 15:33:59 2008
New Revision: 711123
URL: http://svn.apache.org/viewvc?rev=711123&view=rev
Log:
Adding constructors to ResultImpl to work around the SQLException hiding in ResultSupport - and noted this in ResultSupport as per #46086
Modified:
jakarta/taglibs/proper/standard/trunk/src/javax/servlet/jsp/jstl/sql/ResultSupport.java
jakarta/taglibs/proper/standard/trunk/src/org/apache/taglibs/standard/tag/common/sql/ResultImpl.java
Modified: jakarta/taglibs/proper/standard/trunk/src/javax/servlet/jsp/jstl/sql/ResultSupport.java
URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/standard/trunk/src/javax/servlet/jsp/jstl/sql/ResultSupport.java?rev=711123&r1=711122&r2=711123&view=diff
==============================================================================
--- jakarta/taglibs/proper/standard/trunk/src/javax/servlet/jsp/jstl/sql/ResultSupport.java (original)
+++ jakarta/taglibs/proper/standard/trunk/src/javax/servlet/jsp/jstl/sql/ResultSupport.java Mon Nov 3 15:33:59 2008
@@ -26,8 +26,11 @@
* easier for page authors to access and manipulate the data resulting
* from a SQL query.</p>
*
- * @author Justyna Horwat
+ * Note that these methods hide any SQLExceptions that are caused and return
+ * null - to work around that
+ * use org.apache.taglibs.standard.tag.common.sql.ResultImpl directly.
*
+ * @author Justyna Horwat
*/
public class ResultSupport {
Modified: jakarta/taglibs/proper/standard/trunk/src/org/apache/taglibs/standard/tag/common/sql/ResultImpl.java
URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/standard/trunk/src/org/apache/taglibs/standard/tag/common/sql/ResultImpl.java?rev=711123&r1=711122&r2=711123&view=diff
==============================================================================
--- jakarta/taglibs/proper/standard/trunk/src/org/apache/taglibs/standard/tag/common/sql/ResultImpl.java (original)
+++ jakarta/taglibs/proper/standard/trunk/src/org/apache/taglibs/standard/tag/common/sql/ResultImpl.java Mon Nov 3 15:33:59 2008
@@ -47,6 +47,29 @@
private boolean isLimited;
/**
+ * Build a <code>Result</code> object from a <code>ResultSet</code> object.
+ *
+ * @param rs an open <tt>ResultSet</tt>, positioned before the first row
+ * @exception if a database error occurs
+ */
+ public ResultImpl(ResultSet rs) throws SQLException {
+ this(rs, -1, -1);
+ }
+
+ /**
+ * Build a <code>Result</code> object from a <code>ResultSet</code> object.
+ *
+ * @param rs an open <tt>ResultSet</tt>, positioned before the first row
+ * @param maxRows, query maximum rows limit
+ * @exception if a database error occurs
+ */
+ public ResultImpl(ResultSet rs, int maxRows) throws SQLException {
+ // Matching API in ResultSupport - apologies for the bad
+ // order of default parameters
+ this(rs, -1, maxRows);
+ }
+
+ /**
* This constructor reads the ResultSet and saves a cached
* copy.
*
---------------------------------------------------------------------
To unsubscribe, e-mail: taglibs-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: taglibs-dev-help@jakarta.apache.org