You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/10/16 05:44:12 UTC

[GitHub] [geode-native] albertogpz commented on pull request #676: GEODE-8613: Removing exclusive access to creation/closing of pool connections

albertogpz commented on pull request #676:
URL: https://github.com/apache/geode-native/pull/676#issuecomment-709806312


   > I need more time to review this for correctness. I think the locking is required here to both protect concurrent updates to the `m_poolSize` value in various places as well as synchronize the CPU caches of this member.
   
   Wouldn't that already be guaranteed given that the type of `m_poolSize` is `std::atomic<int32_t>`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org