You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/23 05:59:36 UTC
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15312: [Bug](timediff) Fix wrong result for function `timediff`
github-actions[bot] commented on code in PR #15312:
URL: https://github.com/apache/doris/pull/15312#discussion_r1056061188
##########
be/test/vec/function/function_test_util.h:
##########
@@ -233,7 +234,8 @@
fn_ctx_return.type = doris_udf::FunctionContext::TYPE_BOOLEAN;
} else if constexpr (std::is_same_v<ReturnType, DataTypeInt32>) {
fn_ctx_return.type = doris_udf::FunctionContext::TYPE_INT;
- } else if constexpr (std::is_same_v<ReturnType, DataTypeFloat64>) {
+ } else if constexpr (std::is_same_v < ReturnType,
+ DataTypeFloat64 || std::is_same_v<ReturnType, DataTypeTime>) {
Review Comment:
warning: expected unqualified-id [clang-diagnostic-error]
```cpp
DataTypeFloat64 || std::is_same_v<ReturnType, DataTypeTime>) {
^
```
##########
be/test/vec/function/function_test_util.h:
##########
@@ -233,7 +234,8 @@
fn_ctx_return.type = doris_udf::FunctionContext::TYPE_BOOLEAN;
} else if constexpr (std::is_same_v<ReturnType, DataTypeInt32>) {
fn_ctx_return.type = doris_udf::FunctionContext::TYPE_INT;
- } else if constexpr (std::is_same_v<ReturnType, DataTypeFloat64>) {
+ } else if constexpr (std::is_same_v < ReturnType,
+ DataTypeFloat64 || std::is_same_v<ReturnType, DataTypeTime>) {
Review Comment:
warning: type name requires a specifier or qualifier [clang-diagnostic-error]
```cpp
DataTypeFloat64 || std::is_same_v<ReturnType, DataTypeTime>) {
^
```
##########
be/test/vec/function/function_test_util.h:
##########
@@ -233,7 +234,8 @@ Status check_function(const std::string& func_name, const InputTypeSet& input_ty
fn_ctx_return.type = doris_udf::FunctionContext::TYPE_BOOLEAN;
} else if constexpr (std::is_same_v<ReturnType, DataTypeInt32>) {
fn_ctx_return.type = doris_udf::FunctionContext::TYPE_INT;
- } else if constexpr (std::is_same_v<ReturnType, DataTypeFloat64>) {
+ } else if constexpr (std::is_same_v < ReturnType,
+ DataTypeFloat64 || std::is_same_v<ReturnType, DataTypeTime>) {
Review Comment:
warning: expected '>' [clang-diagnostic-error]
```cpp
DataTypeFloat64 || std::is_same_v<ReturnType, DataTypeTime>) {
^
```
**be/test/vec/function/function_test_util.h:236:** to match this '<'
```cpp
} else if constexpr (std::is_same_v < ReturnType,
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org