You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2022/02/17 21:36:15 UTC
[kudu-CR] [security] harmonize tls handshake.cc
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18246
Change subject: [security] harmonize tls_handshake.cc
......................................................................
[security] harmonize tls_handshake.cc
The first parameter of Socket.Write() is of type `const uint8_t *`. This
resulted in a warning in TlsHandshake::Finish(). This caused an Impala
build failure since the warning was treated as an error.
This is a follow-up to df6590d26d.
Change-Id: Iddf1bd7ee39ea74eff74871c83c5159e53fc7377
---
M src/kudu/security/tls_handshake.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/18246/1
--
To view, visit http://gerrit.cloudera.org:8080/18246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iddf1bd7ee39ea74eff74871c83c5159e53fc7377
Gerrit-Change-Number: 18246
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] [security] harmonize tls handshake.cc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18246 )
Change subject: [security] harmonize tls_handshake.cc
......................................................................
[security] harmonize tls_handshake.cc
The first parameter of Socket.Write() is of type `const uint8_t *`. This
resulted in a warning in TlsHandshake::Finish(). This caused an Impala
build failure since the warning was treated as an error.
This is a follow-up to df6590d26d.
Change-Id: Iddf1bd7ee39ea74eff74871c83c5159e53fc7377
Reviewed-on: http://gerrit.cloudera.org:8080/18246
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/security/tls_handshake.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iddf1bd7ee39ea74eff74871c83c5159e53fc7377
Gerrit-Change-Number: 18246
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [security] harmonize tls handshake.cc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18246 )
Change subject: [security] harmonize tls_handshake.cc
......................................................................
Patch Set 1: Verified+1
unrelated test failures
--
To view, visit http://gerrit.cloudera.org:8080/18246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddf1bd7ee39ea74eff74871c83c5159e53fc7377
Gerrit-Change-Number: 18246
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Feb 2022 22:36:12 +0000
Gerrit-HasComments: No
[kudu-CR] [security] harmonize tls handshake.cc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [security] harmonize tls_handshake.cc
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Iddf1bd7ee39ea74eff74871c83c5159e53fc7377
Gerrit-Change-Number: 18246
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [security] harmonize tls handshake.cc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18246 )
Change subject: [security] harmonize tls_handshake.cc
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddf1bd7ee39ea74eff74871c83c5159e53fc7377
Gerrit-Change-Number: 18246
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Feb 2022 22:37:18 +0000
Gerrit-HasComments: No