You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "weizhouapache (via GitHub)" <gi...@apache.org> on 2023/10/06 07:25:42 UTC
[PR] systemvm: remove config in /etc/pam.d/systemd-user to fix user@0.service [cloudstack]
weizhouapache opened a new pull request, #8048:
URL: https://github.com/apache/cloudstack/pull/8048
### Description
the service `user@0.service` fails in system vms and virtual routers
This PR removes a change to fix memory leak of SSH connections in the systemvm templates with old linux kernel.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm: remove config in /etc/pam.d/systemd-user to fix user@0.service [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #8048:
URL: https://github.com/apache/cloudstack/pull/8048#issuecomment-1754892840
@weizhouapache @DaanHoogland @harikrishna-patnala I'm assuming this doesn't require a systemvmtemplate build (since changes are not in the cloud-early-config ?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm: remove config in /etc/pam.d/systemd-user to fix user@0.service [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8048:
URL: https://github.com/apache/cloudstack/pull/8048#issuecomment-1750118521
@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm: remove config in /etc/pam.d/systemd-user to fix user@0.service [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #8048:
URL: https://github.com/apache/cloudstack/pull/8048#issuecomment-1759179628
Thanks @shwstppr @weizhouapache - that seems to be correct, but the other question is - is this fixing any issue? Is the failure of the service causing issues with systemvms and vrouters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm: remove config in /etc/pam.d/systemd-user to fix user@0.service [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #8048:
URL: https://github.com/apache/cloudstack/pull/8048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm: remove config in /etc/pam.d/systemd-user to fix user@0.service [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8048:
URL: https://github.com/apache/cloudstack/pull/8048#issuecomment-1759280956
@rohityadavcloud
this fixes the service user@0.service in VRs and system vms.
but It seems other services in the vms are not impacted by the failure with `user@0.service`. this is a minor/trivial issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm: remove config in /etc/pam.d/systemd-user to fix user@0.service [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8048:
URL: https://github.com/apache/cloudstack/pull/8048#issuecomment-1754819284
> @weizhouapache this will require new systemvm template?
@shwstppr
I think so
the changes with `init.sh` and `cloud-early-config` require new systemvm template
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm: remove config in /etc/pam.d/systemd-user to fix user@0.service [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #8048:
URL: https://github.com/apache/cloudstack/pull/8048#issuecomment-1759435920
Thanks for checking @weizhouapache cc @shwstppr - if necessary let's build systemvmtemplate for 4.19.0 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm: remove config in /etc/pam.d/systemd-user to fix user@0.service [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8048:
URL: https://github.com/apache/cloudstack/pull/8048#issuecomment-1750198993
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm: remove config in /etc/pam.d/systemd-user to fix user@0.service [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8048:
URL: https://github.com/apache/cloudstack/pull/8048#issuecomment-1750209880
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8048?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#8048](https://app.codecov.io/gh/apache/cloudstack/pull/8048?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (29cddc7) into [4.18](https://app.codecov.io/gh/apache/cloudstack/commit/3d8cc63bc32ee374d22e42de44619bdce65c5e33?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3d8cc63) will **decrease** coverage by `0.01%`.
> Report is 3 commits behind head on 4.18.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 4.18 #8048 +/- ##
============================================
- Coverage 13.07% 13.06% -0.01%
+ Complexity 9107 9106 -1
============================================
Files 2720 2720
Lines 257513 257513
Branches 40151 40151
============================================
- Hits 33658 33649 -9
- Misses 219624 219634 +10
+ Partials 4231 4230 -1
```
[see 1 file with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/8048/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm: remove config in /etc/pam.d/systemd-user to fix user@0.service [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8048:
URL: https://github.com/apache/cloudstack/pull/8048#issuecomment-1750115840
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm: remove config in /etc/pam.d/systemd-user to fix user@0.service [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8048:
URL: https://github.com/apache/cloudstack/pull/8048#issuecomment-1750111036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm: remove config in /etc/pam.d/systemd-user to fix user@0.service [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8048:
URL: https://github.com/apache/cloudstack/pull/8048#issuecomment-1754926306
@rohityadavcloud This may require new systemvm template build. https://github.com/apache/cloudstack/pull/8048#issuecomment-1754819284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm: remove config in /etc/pam.d/systemd-user to fix user@0.service [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8048:
URL: https://github.com/apache/cloudstack/pull/8048#issuecomment-1754750375
@weizhouapache this will require new systemvm template?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org