You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "arnabnandy7 (via GitHub)" <gi...@apache.org> on 2026/08/29 16:34:27 UTC
[PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
arnabnandy7 opened a new pull request, #23310:
URL: https://github.com/apache/kafka/pull/23310
## Summary
KAFKA-19028 identifies inconsistent `AlterConfigPolicy` behavior for incremental DELETE operations. Deleting an unset topic configuration produced no `ConfigRecord`, causing the configuration to be omitted from `RequestMetadata.configs()`. Broker deletions were instead represented as a key mapped to `null`.
This change ensures every explicit incremental DELETE operation is passed to `AlterConfigPolicy` as a configuration key mapped to `null`, even when the resource has no existing override and no metadata record is generated.
The existing behavior for SET, APPEND, SUBTRACT, and the legacy AlterConfigs API remains unchanged.
The `AlterConfigPolicy.RequestMetadata.configs()` Javadoc now documents how incremental DELETE operations are represented.
## Testing
Added a focused unit test covering explicit deletion of unset topic and broker configurations. The test verifies that both resource types produce consistent policy metadata containing the deleted key mapped to `null`.
```text
./gradlew :metadata:test --tests org.apache.kafka.controller.ConfigurationControlManagerTest
./gradlew :clients:test --tests org.apache.kafka.server.policy.AlterConfigPolicyTest
./gradlew spotlessCheck
```
Reviewers: Edoardo Comar @edoardocomar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "arnabnandy7 (via GitHub)" <gi...@apache.org>.
arnabnandy7 commented on code in PR #23310:
URL: https://github.com/apache/kafka/pull/23310#discussion_r4078892299
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -311,6 +312,7 @@ private ApiError incrementalAlterConfigResource(
break;
case DELETE:
newValue = null;
+ explicitlyDeletedConfigs.add(key);
Review Comment:
@chia7712 I raised access with `arnabnandy7` user name in confluence
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #23310:
URL: https://github.com/apache/kafka/pull/23310#discussion_r4062992415
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -311,6 +312,7 @@ private ApiError incrementalAlterConfigResource(
break;
case DELETE:
newValue = null;
+ explicitlyDeletedConfigs.add(key);
Review Comment:
[KIP-1252](https://github.com/apache/kafka/pull/23310/...) added a flag to make the ZK behavior compatible with KRaft, and now this PR changes the KRaft behavior that the flag emulates. I'm not sure how users upgrading from 3.9 to 4.x with alter.config.policy.kraft.compatibility.enable=true will handle that.
Maybe a better way is to leave configs() as it is and have a KIP to add two methods to RequestMetadata: one returning the deleted keys, and one returning the configs without null values. That gives policies an explicit way to see deletions without changing the existing behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "arnabnandy7 (via GitHub)" <gi...@apache.org>.
arnabnandy7 commented on code in PR #23310:
URL: https://github.com/apache/kafka/pull/23310#discussion_r4075176587
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -311,6 +312,7 @@ private ApiError incrementalAlterConfigResource(
break;
case DELETE:
newValue = null;
+ explicitlyDeletedConfigs.add(key);
Review Comment:
@chia7712 I don't have Kafka confluence access yet, I've raised the same but I don't know how much time it'll be required to create an account and provide me with credentials. Instead I'm sharing this draft markdown formated KIP with you, please create this for me.
[KIP-expose-explicit-deletions-to-alter-config-policy.md](https://github.com/user-attachments/files/32531947/KIP-expose-explicit-deletions-to-alter-config-policy.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #23310:
URL: https://github.com/apache/kafka/pull/23310#discussion_r4067653079
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -311,6 +312,7 @@ private ApiError incrementalAlterConfigResource(
break;
case DELETE:
newValue = null;
+ explicitlyDeletedConfigs.add(key);
Review Comment:
I don't think #23545 fully addresses the issue I mentioned. First, changing the public interface generally requires a KIP. Second, this seems to conflict with the compatibility goals introduced by KIP-1252.
In my opinion, it might be safer to revert this PR and propose a KIP to properly accommodate the changes in #23543. @edoardocomar @arnabnandy7 WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #23310:
URL: https://github.com/apache/kafka/pull/23310#discussion_r4067653079
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -311,6 +312,7 @@ private ApiError incrementalAlterConfigResource(
break;
case DELETE:
newValue = null;
+ explicitlyDeletedConfigs.add(key);
Review Comment:
I don't think #23545 fully addresses the issue I mentioned. First, changing the public interface generally requires a KIP. Second, this seems to conflict with the compatibility goals introduced by KIP-1252.
In my opinion, it might be safer to revert this PR and propose a KIP to properly accommodate the changes in #23545. @edoardocomar @arnabnandy7 WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "edoardocomar (via GitHub)" <gi...@apache.org>.
edoardocomar commented on PR #23310:
URL: https://github.com/apache/kafka/pull/23310#issuecomment-5733589468
Thank you for your patch @arnabnandy7 - the fix is small and I like it!
I personally found the test required a bit of navigating to see what it meant to be asserting, it's not obvious to me.
Perhaps an explicit check of what args the policy has received would have been more verbose but also more intent-telling for me.
I enabled the additional workflows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "arnabnandy7 (via GitHub)" <gi...@apache.org>.
arnabnandy7 commented on PR #23310:
URL: https://github.com/apache/kafka/pull/23310#issuecomment-5733658226
> Thank you for your patch @arnabnandy7 - the fix is small and I like it!
>
> I personally found the test required a bit of navigating to see what it meant to be asserting, it's not obvious to me. Perhaps an explicit check of what args the policy has received would have been more verbose but also more intent-telling for me.
>
> I enabled the additional workflows
@edoardocomar let me check I'll amend the tests as you've suggested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "arnabnandy7 (via GitHub)" <gi...@apache.org>.
arnabnandy7 commented on code in PR #23310:
URL: https://github.com/apache/kafka/pull/23310#discussion_r4079328731
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -311,6 +312,7 @@ private ApiError incrementalAlterConfigResource(
break;
case DELETE:
newValue = null;
+ explicitlyDeletedConfigs.add(key);
Review Comment:
@chia7712 thanks, I'll wait for the account availability then create the KIP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #23310:
URL: https://github.com/apache/kafka/pull/23310#issuecomment-5805069169
> I was a bit surprised you chose that [KAFKA-19028](https://issues.apache.org/jira/browse/KAFKA-19028) is a won't fix and went for a KIP instead.
I have changed the resolution from Won't Fix to Duplicate and added the link to KAFKA-21147.
> Not my preference, but no objections.
Sorry, I should have waited for your reply before reverting. My point was that this PR changes the public API. In particular, KIP-1252 added a flag to 3.9 so that policies see the "KRaft behavior". Users who enabled that flag and then migrated to 4.x would be very surprised to find the behavior changed in a minor upgrade without any KIP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "arnabnandy7 (via GitHub)" <gi...@apache.org>.
arnabnandy7 commented on code in PR #23310:
URL: https://github.com/apache/kafka/pull/23310#discussion_r4078892299
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -311,6 +312,7 @@ private ApiError incrementalAlterConfigResource(
break;
case DELETE:
newValue = null;
+ explicitlyDeletedConfigs.add(key);
Review Comment:
@chia7712 I raised access with `arnabnandy7` user name in Kafka confluence
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23310:
URL: https://github.com/apache/kafka/pull/23310#issuecomment-5556595422
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "edoardocomar (via GitHub)" <gi...@apache.org>.
edoardocomar merged PR #23310:
URL: https://github.com/apache/kafka/pull/23310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #23310:
URL: https://github.com/apache/kafka/pull/23310#discussion_r4079075727
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -311,6 +312,7 @@ private ApiError incrementalAlterConfigResource(
break;
case DELETE:
newValue = null;
+ explicitlyDeletedConfigs.add(key);
Review Comment:
I have approved your request :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "edoardocomar (via GitHub)" <gi...@apache.org>.
edoardocomar commented on PR #23310:
URL: https://github.com/apache/kafka/pull/23310#issuecomment-5804937271
Hi @chia7712 thanks for taking a further look,
I was a bit surprised you chose that [KAFKA-19028](https://issues.apache.org/jira/browse/KAFKA-19028) is a `won't fix` and went for a KIP instead. Not my preference, but no objections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "arnabnandy7 (via GitHub)" <gi...@apache.org>.
arnabnandy7 commented on code in PR #23310:
URL: https://github.com/apache/kafka/pull/23310#discussion_r4064527508
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -311,6 +312,7 @@ private ApiError incrementalAlterConfigResource(
break;
case DELETE:
newValue = null;
+ explicitlyDeletedConfigs.add(key);
Review Comment:
@chia7712 thanks for catching the KIP-1252 compatibility issue. I hadn’t accounted for clusters using the 3.9.2 flag to match KRaft’s existing behavior.
I’ve opened a follow-up PR (#23545) that restores that behavior and adds a test covering DELETE for both unset and stored topic configs, as well as an unset broker config. I also clarified the `configs()` Javadoc. The original inconsistency remains, but I agree that exposing deletions explicitly is better handled through a separate KIP than by changing what existing policies receive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "edoardocomar (via GitHub)" <gi...@apache.org>.
edoardocomar commented on PR #23310:
URL: https://github.com/apache/kafka/pull/23310#issuecomment-5740506482
nice thank you, I re-started the workflows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #23310:
URL: https://github.com/apache/kafka/pull/23310#issuecomment-5789156262
I have reverted this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #23310:
URL: https://github.com/apache/kafka/pull/23310#discussion_r4078356780
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -311,6 +312,7 @@ private ApiError incrementalAlterConfigResource(
break;
case DELETE:
newValue = null;
+ explicitlyDeletedConfigs.add(key);
Review Comment:
@arnabnandy7 would you mind sharing you account with me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "arnabnandy7 (via GitHub)" <gi...@apache.org>.
arnabnandy7 commented on code in PR #23310:
URL: https://github.com/apache/kafka/pull/23310#discussion_r4075176587
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -311,6 +312,7 @@ private ApiError incrementalAlterConfigResource(
break;
case DELETE:
newValue = null;
+ explicitlyDeletedConfigs.add(key);
Review Comment:
@chia7712 I don't have Kafka confluence access yet, I've raised the same but I don't know how much time it'll be required to create an account and provide me with credentials. Instead I'm sharing this draft markdown formated KIP with you, please create this for me.
[KIP-expose-explicit-deletions-to-alter-config-policy.md](https://github.com/user-attachments/files/32531947/KIP-expose-explicit-deletions-to-alter-config-policy.md)
It follows the official [Kafka KIP template](https://cwiki.apache.org/confluence/spaces/KAFKA/pages/50859709/KIP-Template)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "arnabnandy7 (via GitHub)" <gi...@apache.org>.
arnabnandy7 commented on code in PR #23310:
URL: https://github.com/apache/kafka/pull/23310#discussion_r4067930417
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -311,6 +312,7 @@ private ApiError incrementalAlterConfigResource(
break;
case DELETE:
newValue = null;
+ explicitlyDeletedConfigs.add(key);
Review Comment:
@chia7712 not today but tomorrow I'll draft a KIP and share with you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #23310:
URL: https://github.com/apache/kafka/pull/23310#discussion_r4062992415
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -311,6 +312,7 @@ private ApiError incrementalAlterConfigResource(
break;
case DELETE:
newValue = null;
+ explicitlyDeletedConfigs.add(key);
Review Comment:
[KIP-1252](https://cwiki.apache.org/confluence/x/c4XMFw) added a flag to make the ZK behavior compatible with KRaft, and now this PR changes the KRaft behavior that the flag emulates. I'm not sure how users upgrading from 3.9 to 4.x with alter.config.policy.kraft.compatibility.enable=true will handle that.
Maybe a better way is to leave configs() as it is and have a KIP to add two methods to RequestMetadata: one returning the deleted keys, and one returning the configs without null values. That gives policies an explicit way to see deletions without changing the existing behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "arnabnandy7 (via GitHub)" <gi...@apache.org>.
arnabnandy7 commented on PR #23310:
URL: https://github.com/apache/kafka/pull/23310#issuecomment-5734177890
@edoardocomar please review, I've updated the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "arnabnandy7 (via GitHub)" <gi...@apache.org>.
arnabnandy7 commented on code in PR #23310:
URL: https://github.com/apache/kafka/pull/23310#discussion_r4067702954
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -311,6 +312,7 @@ private ApiError incrementalAlterConfigResource(
break;
case DELETE:
newValue = null;
+ explicitlyDeletedConfigs.add(key);
Review Comment:
Sure that's good too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "edoardocomar (via GitHub)" <gi...@apache.org>.
edoardocomar commented on PR #23310:
URL: https://github.com/apache/kafka/pull/23310#issuecomment-5805162526
My preference would be for a KIP that allows for the change in API that this PR implemented.
Would be a change for KRaft users and make the ZK compatibility flag not 100% compatible any more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "arnabnandy7 (via GitHub)" <gi...@apache.org>.
arnabnandy7 commented on PR #23310:
URL: https://github.com/apache/kafka/pull/23310#issuecomment-5742712332
> nice thank you, I re-started the workflows
@edoardocomar looks like it was a clean sweep, let me know if you've any additional findings for me or we can freeze the changes here in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #23310:
URL: https://github.com/apache/kafka/pull/23310#discussion_r4067827892
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -311,6 +312,7 @@ private ApiError incrementalAlterConfigResource(
break;
case DELETE:
newValue = null;
+ explicitlyDeletedConfigs.add(key);
Review Comment:
I will revert this PR tomorrow if there is no objection. @arnabnandy7 Do you have free cycles to write up the KIP? I'm willing to be the reviewer for you :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19028: Make incremental config deletion consistent for policies [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #23310:
URL: https://github.com/apache/kafka/pull/23310#discussion_r4079095868
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -311,6 +312,7 @@ private ApiError incrementalAlterConfigResource(
break;
case DELETE:
newValue = null;
+ explicitlyDeletedConfigs.add(key);
Review Comment:
@arnabnandy7 I've opened https://issues.apache.org/jira/browse/KAFKA-21147 for you. Please feel free to take it over
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org