[GitHub] [incubator-pinot] siddharthteotia commented on pull request #5642: Add more schema validations

[GitBox <gi...@apache.org>]

siddharthteotia commented on pull request #5642:
URL: https://github.com/apache/incubator-pinot/pull/5642#issuecomment-657709339


   > > @mayankshriv @siddharthteotia Please verify that LinkedIn use cases are not using the preserved SQL keyword as the column name
   > 
   > I believe some reserved keywords are being used. You will want to do this
   > 
   > ```
   > A queryParam validateFieldNames has been provided to the /add /update and /validate schema calls. It is by default true. For operations on schemas with invalid field names to be successful, this flag needs to be set to false.
   > ```
   
   IIUC, this will require use cases at Li to change their application code and pass this param. I have seen use cases having reserved keywords (like date, count etc) as field names. Calcite allows us to escape and that was the original plan to work around this problem when migrating to SQL. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org