You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2016/01/12 23:06:00 UTC

Re: Review Request 42211: Added filters to disable NetClsIsolator tests in case cgroups is not present or the net_cls subsystem is disable.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42211/
-----------------------------------------------------------

(Updated Jan. 12, 2016, 10:05 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4262
    https://issues.apache.org/jira/browse/MESOS-4262


Repository: mesos


Description
-------

Added filters to disable NetClsIsolator tests in case cgroups is not present or the net_cls subsystem is disable.


Diffs
-----

  src/tests/environment.cpp 36f0ad0b739559e5c883d72585731944da4283cf 

Diff: https://reviews.apache.org/r/42211/diff/


Testing
-------

make check

* Tested the filter by disabling cls_group.ko (module for net_cls cgroup). The NetClsIsolator tests were correctly disabled when I ran make check with the filter set to NetClsIsolatorTest.ROOT_CGROUPS_NetClsIsolate


Thanks,

Avinash sridharan

Re: Review Request 42211: Added filters to disable NetClsIsolator tests in case the net_cls cgroup subsystem is disabled.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42211/#review115386
-----------------------------------------------------------


Bad patch!

Reviews applied: [42047]

Failed command: ./support/apply-review.sh -n -r 42047

Error:
 2016-01-20 09:00:52 URL:https://reviews.apache.org/r/42047/diff/raw/ [9082/9082] -> "42047.patch" [1]
Total errors found: 0
Checking 2 files
Error: Commit message summary (the first line) must not exceed 72 characters.

- Mesos ReviewBot


On Jan. 20, 2016, 5:15 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42211/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 5:15 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4262
>     https://issues.apache.org/jira/browse/MESOS-4262
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added filters to disable NetClsIsolator tests in case the net_cls cgroup subsystem is disabled.
> 
> 
> Diffs
> -----
> 
>   src/tests/environment.cpp a6322f260c23796ceaa5d2080126ea9fef0b5ac6 
> 
> Diff: https://reviews.apache.org/r/42211/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> * Tested the filter by disabling cls_group.ko (module for net_cls cgroup). The NetClsIsolator tests were correctly disabled when I ran make check with the filter set to NetClsIsolatorTest.ROOT_CGROUPS_NetClsIsolate
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 42211: Added filters to disable NetClsIsolator tests in case the net_cls cgroup subsystem is disabled.

Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42211/
-----------------------------------------------------------

(Updated Jan. 20, 2016, 5:15 a.m.)


Review request for mesos and Jie Yu.


Summary (updated)
-----------------

Added filters to disable NetClsIsolator tests in case the net_cls cgroup subsystem is disabled.


Bugs: MESOS-4262
    https://issues.apache.org/jira/browse/MESOS-4262


Repository: mesos


Description (updated)
-------

Added filters to disable NetClsIsolator tests in case the net_cls cgroup subsystem is disabled.


Diffs (updated)
-----

  src/tests/environment.cpp a6322f260c23796ceaa5d2080126ea9fef0b5ac6 

Diff: https://reviews.apache.org/r/42211/diff/


Testing
-------

make check

* Tested the filter by disabling cls_group.ko (module for net_cls cgroup). The NetClsIsolator tests were correctly disabled when I ran make check with the filter set to NetClsIsolatorTest.ROOT_CGROUPS_NetClsIsolate


Thanks,

Avinash sridharan

Re: Review Request 42211: Added filters to disable NetClsIsolator tests.

Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42211/
-----------------------------------------------------------

(Updated Jan. 19, 2016, 3:23 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4262
    https://issues.apache.org/jira/browse/MESOS-4262


Repository: mesos


Description
-------

Added filters to disable NetClsIsolator tests in case cgroups is not present or the net_cls subsystem is disable.


Diffs (updated)
-----

  src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787 

Diff: https://reviews.apache.org/r/42211/diff/


Testing
-------

make check

* Tested the filter by disabling cls_group.ko (module for net_cls cgroup). The NetClsIsolator tests were correctly disabled when I ran make check with the filter set to NetClsIsolatorTest.ROOT_CGROUPS_NetClsIsolate


Thanks,

Avinash sridharan

Re: Review Request 42211: Added filters to disable NetClsIsolator tests.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42211/#review115068
-----------------------------------------------------------

Ship it!



src/tests/environment.cpp (line 388)
<https://reviews.apache.org/r/42211/#comment175920>

    Could you please add a comment about why we need a seprate filter for net_cls, instead of relying on the existing cgroups filter? (e.g., net_cls is not always available on systems with cgroups enabled)



src/tests/environment.cpp (line 394)
<https://reviews.apache.org/r/42211/#comment175921>

    space before 'netCls'



src/tests/environment.cpp (line 395)
<https://reviews.apache.org/r/42211/#comment175930>

    Can you move this above #ifdef linux?



src/tests/environment.cpp (lines 400 - 401)
<https://reviews.apache.org/r/42211/#comment175927>

    Can you adjust the message here. In other words, please do not let the message be longer than the '-' bar.



src/tests/environment.cpp (lines 409 - 411)
<https://reviews.apache.org/r/42211/#comment175932>

    Ditto on message formatting.



src/tests/environment.cpp (line 417)
<https://reviews.apache.org/r/42211/#comment175931>

    No need for this as I suggested above.



src/tests/environment.cpp (line 429)
<https://reviews.apache.org/r/42211/#comment175929>

    indent please


- Jie Yu


On Jan. 15, 2016, 5:42 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42211/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 5:42 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4262
>     https://issues.apache.org/jira/browse/MESOS-4262
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added filters to disable NetClsIsolator tests in case cgroups is not present or the net_cls subsystem is disable.
> 
> 
> Diffs
> -----
> 
>   src/tests/environment.cpp 36f0ad0b739559e5c883d72585731944da4283cf 
> 
> Diff: https://reviews.apache.org/r/42211/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> * Tested the filter by disabling cls_group.ko (module for net_cls cgroup). The NetClsIsolator tests were correctly disabled when I ran make check with the filter set to NetClsIsolatorTest.ROOT_CGROUPS_NetClsIsolate
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 42211: Added filters to disable NetClsIsolator tests.

Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42211/
-----------------------------------------------------------

(Updated Jan. 15, 2016, 5:42 p.m.)


Review request for mesos and Jie Yu.


Summary (updated)
-----------------

Added filters to disable NetClsIsolator tests.


Bugs: MESOS-4262
    https://issues.apache.org/jira/browse/MESOS-4262


Repository: mesos


Description
-------

Added filters to disable NetClsIsolator tests in case cgroups is not present or the net_cls subsystem is disable.


Diffs
-----

  src/tests/environment.cpp 36f0ad0b739559e5c883d72585731944da4283cf 

Diff: https://reviews.apache.org/r/42211/diff/


Testing
-------

make check

* Tested the filter by disabling cls_group.ko (module for net_cls cgroup). The NetClsIsolator tests were correctly disabled when I ran make check with the filter set to NetClsIsolatorTest.ROOT_CGROUPS_NetClsIsolate


Thanks,

Avinash sridharan

Re: Review Request 42211: Added filters to disable NetClsIsolator tests in case cgroups is not present or the net_cls subsystem is disable.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42211/#review114273
-----------------------------------------------------------


Bad patch!

Reviews applied: [42047]

Failed command: ./support/apply-review.sh -n -r 42047

Error:
 2016-01-13 20:49:34 URL:https://reviews.apache.org/r/42047/diff/raw/ [9619/9619] -> "42047.patch" [1]
Total errors found: 0
Checking 2 files
Error: Commit message summary (the first line) must not exceed 72 characters.

- Mesos ReviewBot


On Jan. 13, 2016, 5:52 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42211/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 5:52 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4262
>     https://issues.apache.org/jira/browse/MESOS-4262
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added filters to disable NetClsIsolator tests in case cgroups is not present or the net_cls subsystem is disable.
> 
> 
> Diffs
> -----
> 
>   src/tests/environment.cpp 36f0ad0b739559e5c883d72585731944da4283cf 
> 
> Diff: https://reviews.apache.org/r/42211/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> * Tested the filter by disabling cls_group.ko (module for net_cls cgroup). The NetClsIsolator tests were correctly disabled when I ran make check with the filter set to NetClsIsolatorTest.ROOT_CGROUPS_NetClsIsolate
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 42211: Added filters to disable NetClsIsolator tests in case cgroups is not present or the net_cls subsystem is disable.

Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42211/
-----------------------------------------------------------

(Updated Jan. 13, 2016, 5:52 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4262
    https://issues.apache.org/jira/browse/MESOS-4262


Repository: mesos


Description
-------

Added filters to disable NetClsIsolator tests in case cgroups is not present or the net_cls subsystem is disable.


Diffs (updated)
-----

  src/tests/environment.cpp 36f0ad0b739559e5c883d72585731944da4283cf 

Diff: https://reviews.apache.org/r/42211/diff/


Testing
-------

make check

* Tested the filter by disabling cls_group.ko (module for net_cls cgroup). The NetClsIsolator tests were correctly disabled when I ran make check with the filter set to NetClsIsolatorTest.ROOT_CGROUPS_NetClsIsolate


Thanks,

Avinash sridharan