You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/10/11 09:48:02 UTC
Review Request: Added some more logging output to mesos-executor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7538/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Description
-------
See summary.
Diffs
-----
src/launcher/executor.cpp fa5a5ed29ebbdbb98e68817968d52ac4946fc257
Diff: https://reviews.apache.org/r/7538/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Added some more logging output to mesos-executor.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7538/
-----------------------------------------------------------
(Updated Oct. 13, 2012, 12:01 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Updates from review comments.
Description
-------
See summary.
Diffs (updated)
-----
src/launcher/executor.cpp fa5a5ed29ebbdbb98e68817968d52ac4946fc257
Diff: https://reviews.apache.org/r/7538/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Added some more logging output to mesos-executor.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7538/#review12371
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Oct. 11, 2012, 7:48 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7538/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2012, 7:48 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp fa5a5ed29ebbdbb98e68817968d52ac4946fc257
>
> Diff: https://reviews.apache.org/r/7538/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added some more logging output to mesos-executor.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Oct. 11, 2012, 5:21 p.m., Vinod Kone wrote:
> > src/launcher/executor.cpp, line 125
> > <https://reviews.apache.org/r/7538/diff/1/?file=175691#file175691line125>
> >
> > please include the task.command().value() in cerr.
> >
> > Also, curious, why cerr and abort instead of PLOG?
Done, thanks!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7538/#review12332
-----------------------------------------------------------
On Oct. 11, 2012, 7:48 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7538/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2012, 7:48 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp fa5a5ed29ebbdbb98e68817968d52ac4946fc257
>
> Diff: https://reviews.apache.org/r/7538/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added some more logging output to mesos-executor.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7538/#review12332
-----------------------------------------------------------
Ship it!
src/launcher/executor.cpp
<https://reviews.apache.org/r/7538/#comment26108>
please include the task.command().value() in cerr.
Also, curious, why cerr and abort instead of PLOG?
- Vinod Kone
On Oct. 11, 2012, 7:48 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7538/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2012, 7:48 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp fa5a5ed29ebbdbb98e68817968d52ac4946fc257
>
> Diff: https://reviews.apache.org/r/7538/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>