[GitHub] [hudi] nsivabalan commented on a change in pull request #4743: [HUDI-3280][Stacked on 4669] Cleaning up Hive-related hierarchies after refactoring

[GitBox <gi...@apache.org>]

nsivabalan commented on a change in pull request #4743:
URL: https://github.com/apache/hudi/pull/4743#discussion_r799875922



##########
File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/HoodieRealtimePath.java
##########
@@ -100,13 +105,12 @@ public boolean includeBootstrapFilePath() {
     return pathWithBootstrapFileStatus != null;
   }
 
-  public BaseFileWithLogsSplit buildSplit(Path file, long start, long length, String[] hosts) {
-    BaseFileWithLogsSplit bs = new BaseFileWithLogsSplit(file, start, length, hosts);
-    bs.setBelongsToIncrementalQuery(belongsToIncrementalPath);
+  public HoodieRealtimeFileSplit buildSplit(Path file, long start, long length, String[] hosts) {
+    HoodieRealtimeFileSplit bs = new HoodieRealtimeFileSplit(file, start, length, hosts);
+    bs.setBelongsToIncrementalQuery(belongsToIncrementalQuery);

Review comment:
       why pathWithBootstrapFileStatus is not considered in this buildSplit? or don't we need to have another builder ? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org