You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by felixcheung <gi...@git.apache.org> on 2017/12/29 20:09:50 UTC
[GitHub] spark pull request #20118: [SPARK-22924][SPARKR] R API for sortWithinPartiti...
GitHub user felixcheung opened a pull request:
https://github.com/apache/spark/pull/20118
[SPARK-22924][SPARKR] R API for sortWithinPartitions
## What changes were proposed in this pull request?
Add to `arrange` option to sort only within partition
## How was this patch tested?
manual, unit tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/felixcheung/spark rsortwithinpartition
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20118.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20118
----
commit c10bc8e8bb03be4a62aeeb24a140f99457cebc83
Author: Felix Cheung <fe...@...>
Date: 2017-12-29T20:05:24Z
sortWithinPartitions
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20118: [SPARK-22924][SPARKR] R API for sortWithinPartitions
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20118
Merged to master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20118: [SPARK-22924][SPARKR] R API for sortWithinPartitions
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20118
@shivaram @HyukjinKwon what do you think about this approach?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20118: [SPARK-22924][SPARKR] R API for sortWithinPartitions
Posted by shivaram <gi...@git.apache.org>.
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/20118
LGTM. I think withinPartitions sounds better than global
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20118: [SPARK-22924][SPARKR] R API for sortWithinPartitions
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20118
**[Test build #85523 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85523/testReport)** for PR 20118 at commit [`c10bc8e`](https://github.com/apache/spark/commit/c10bc8e8bb03be4a62aeeb24a140f99457cebc83).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20118: [SPARK-22924][SPARKR] R API for sortWithinPartitions
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20118
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85523/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20118: [SPARK-22924][SPARKR] R API for sortWithinPartitions
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20118
**[Test build #85523 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85523/testReport)** for PR 20118 at commit [`c10bc8e`](https://github.com/apache/spark/commit/c10bc8e8bb03be4a62aeeb24a140f99457cebc83).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20118: [SPARK-22924][SPARKR] R API for sortWithinPartitions
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20118
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20118: [SPARK-22924][SPARKR] R API for sortWithinPartiti...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20118
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org