You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Josef Cacek <no...@github.com> on 2016/01/20 15:20:55 UTC

[jclouds-labs] [JCLOUDS-981,JCLOUDS-982] remove Optional from AzureComputeTemplateOptions (#231)

This PR supercedes https://github.com/jclouds/jclouds-labs/pull/197 (fixes its conflict with commit https://github.com/jclouds/jclouds-labs/commit/f67d2aa7bfb45a6448e8a49a46d12576b4ba5aa5 )

* fix reuse of existing storage service during deployment
* use AutoValue.Builder in DeployParams
* make network creation optional
* remove AzureComuteAdapterLiveTest b/c not meaningful
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs/pull/231

-- Commit Summary --

  * [JCLOUDS-981,JCLOUDS-982] remove Optional from AzureComputeTemplateOptions

-- File Changes --

    M azurecompute/README.md (4)
    M azurecompute/pom.xml (2)
    M azurecompute/src/main/java/org/jclouds/azurecompute/AzureComputeProviderMetadata.java (3)
    M azurecompute/src/main/java/org/jclouds/azurecompute/binders/DeploymentParamsToXML.java (28)
    M azurecompute/src/main/java/org/jclouds/azurecompute/binders/RoleToXML.java (6)
    M azurecompute/src/main/java/org/jclouds/azurecompute/compute/AzureComputeServiceAdapter.java (219)
    M azurecompute/src/main/java/org/jclouds/azurecompute/compute/config/AzureComputeServiceContextModule.java (7)
    M azurecompute/src/main/java/org/jclouds/azurecompute/compute/extensions/AzureComputeSecurityGroupExtension.java (129)
    M azurecompute/src/main/java/org/jclouds/azurecompute/compute/functions/DeploymentToNodeMetadata.java (11)
    M azurecompute/src/main/java/org/jclouds/azurecompute/compute/functions/RoleSizeToHardware.java (31)
    A azurecompute/src/main/java/org/jclouds/azurecompute/compute/options/AzureComputeTemplateOptions.java (418)
    A azurecompute/src/main/java/org/jclouds/azurecompute/compute/predicates/StorageServicePredicates.java (80)
    M azurecompute/src/main/java/org/jclouds/azurecompute/compute/strategy/GetOrCreateStorageServiceAndVirtualNetworkThenCreateNodes.java (194)
    D azurecompute/src/main/java/org/jclouds/azurecompute/compute/strategy/impl/AzureAdaptingComputeServiceStrategies.java (70)
    M azurecompute/src/main/java/org/jclouds/azurecompute/domain/Deployment.java (1)
    M azurecompute/src/main/java/org/jclouds/azurecompute/domain/DeploymentParams.java (165)
    M azurecompute/src/main/java/org/jclouds/azurecompute/features/VirtualMachineApi.java (13)
    D azurecompute/src/main/java/org/jclouds/azurecompute/options/AzureComputeTemplateOptions.java (344)
    M azurecompute/src/main/java/org/jclouds/azurecompute/util/ConflictManagementPredicate.java (7)
    D azurecompute/src/test/java/org/jclouds/azurecompute/AzureComputeProviderMetadataLive.java (86)
    A azurecompute/src/test/java/org/jclouds/azurecompute/binders/DeploymentParamsToXMLTest.java (64)
    D azurecompute/src/test/java/org/jclouds/azurecompute/compute/AzureComputeServiceAdapterLiveTest.java (177)
    M azurecompute/src/test/java/org/jclouds/azurecompute/compute/AzureComputeServiceContextLiveTest.java (139)
    M azurecompute/src/test/java/org/jclouds/azurecompute/compute/AzureComputeServiceLiveTest.java (30)
    M azurecompute/src/test/java/org/jclouds/azurecompute/features/DeploymentApiLiveTest.java (22)
    M azurecompute/src/test/java/org/jclouds/azurecompute/features/DeploymentApiMockTest.java (10)
    M azurecompute/src/test/java/org/jclouds/azurecompute/features/DiskApiLiveTest.java (3)
    M azurecompute/src/test/java/org/jclouds/azurecompute/features/NetworkSecurityGroupApiLiveTest.java (15)
    M azurecompute/src/test/java/org/jclouds/azurecompute/features/OSImageApiLiveTest.java (17)
    M azurecompute/src/test/java/org/jclouds/azurecompute/features/VMImageApiLiveTest.java (33)
    M azurecompute/src/test/java/org/jclouds/azurecompute/features/VirtualMachineApiLiveTest.java (41)
    M azurecompute/src/test/java/org/jclouds/azurecompute/features/VirtualNetworkApiLiveTest.java (35)
    M azurecompute/src/test/java/org/jclouds/azurecompute/internal/AbstractAzureComputeApiLiveTest.java (26)
    M azurecompute/src/test/java/org/jclouds/azurecompute/internal/BaseAzureComputeApiLiveTest.java (5)
    M azurecompute/src/test/resources/deploymentparams-windows.xml (2)
    R azurecompute/src/test/resources/logback-test.xml (0)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/231.patch
https://github.com/jclouds/jclouds-labs/pull/231.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/231

Re: [jclouds-labs] [JCLOUDS-981,JCLOUDS-982] remove Optional from AzureComputeTemplateOptions (#231)

Posted by Josef Cacek <no...@github.com>.

Again the timeout in the jdbc module - as we saw it also in PR#197.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/231#issuecomment-173236130

Re: [jclouds-labs] [JCLOUDS-981,JCLOUDS-982] remove Optional from AzureComputeTemplateOptions (#231)

Posted by Andrea Turli <no...@github.com>.

Thanks @kwart I've rebased and merged #197 which I think it is identical to yours now. 
Feel free to re-open in case I missed something, thanks!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/231#issuecomment-173386550

Re: [jclouds-labs] [JCLOUDS-981,JCLOUDS-982] remove Optional from AzureComputeTemplateOptions (#231)

Posted by Andrea Turli <no...@github.com>.

Closed #231.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/231#event-521029543