You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/03/05 08:34:53 UTC

[GitHub] [incubator-dolphinscheduler] Wuv1Up opened a new pull request #2093: fix typo

Wuv1Up opened a new pull request #2093: fix typo
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2093
 
 
   ## What is the purpose of the pull request
   
   fix typo
   
   ## Brief change log
   
   fix taskAppId comment
   
   ## Verify this pull request
   
   This pull request is code cleanup without any test coverage.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #2093: fix typo

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #2093: fix typo
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2093#issuecomment-595101314
 
 
   SonarCloud Quality Gate failed.
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2093&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2093&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2093&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2093&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2093&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2093&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2093&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2093&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2093&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2093&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2093&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2093&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2093&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2093&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2093&metric=new_duplicated_lines_density&view=list)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] dailidong merged pull request #2093: fix typo

Posted by GitBox <gi...@apache.org>.
dailidong merged pull request #2093: fix typo
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2093
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #2093: fix typo

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #2093: fix typo
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2093#issuecomment-595099744
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2093?src=pr&el=h1) Report
   > Merging [#2093](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2093?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/46f46ed79575d60dc6f83d71e287a85e3fa24721?src=pr&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2093/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2093?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #2093      +/-   ##
   ============================================
   + Coverage     33.14%   33.15%   +0.01%     
   - Complexity     1553     1554       +1     
   ============================================
     Files           313      313              
     Lines         15529    15534       +5     
     Branches       1886     1886              
   ============================================
   + Hits           5147     5151       +4     
     Misses         9852     9852              
   - Partials        530      531       +1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2093?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...dolphinscheduler/server/worker/task/TaskProps.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2093/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL1Rhc2tQcm9wcy5qYXZh) | `36.48% <ø> (ø)` | `19 <0> (ø)` | :arrow_down: |
   | [...he/dolphinscheduler/api/service/LoggerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2093/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvTG9nZ2VyU2VydmljZS5qYXZh) | `91.3% <0%> (-8.7%)` | `7% <0%> (-1%)` | |
   | [...he/dolphinscheduler/server/utils/AlertManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2093/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL0FsZXJ0TWFuYWdlci5qYXZh) | `2.91% <0%> (-0.06%)` | `2% <0%> (ø)` | |
   | [...java/org/apache/dolphinscheduler/dao/AlertDao.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2093/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL0FsZXJ0RGFvLmphdmE=) | `3.33% <0%> (-0.06%)` | `1% <0%> (ø)` | |
   | [...duler/alert/template/impl/DefaultHTMLTemplate.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2093/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9pbXBsL0RlZmF1bHRIVE1MVGVtcGxhdGUuamF2YQ==) | `77.55% <0%> (ø)` | `12% <0%> (ø)` | :arrow_down: |
   | [...ler/server/master/runner/MasterTaskExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2093/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyVGFza0V4ZWNUaHJlYWQuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [...dolphinscheduler/dao/entity/ProcessDefinition.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2093/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Qcm9jZXNzRGVmaW5pdGlvbi5qYXZh) | `37.97% <0%> (ø)` | `25% <0%> (ø)` | :arrow_down: |
   | [.../dolphinscheduler/dao/upgrade/MysqlUpgradeDao.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2093/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3VwZ3JhZGUvTXlzcWxVcGdyYWRlRGFvLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [...e/dolphinscheduler/common/log/WorkerLogFilter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2093/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2xvZy9Xb3JrZXJMb2dGaWx0ZXIuamF2YQ==) | `33.33% <0%> (ø)` | `2% <0%> (ø)` | :arrow_down: |
   | [...rg/apache/dolphinscheduler/dao/entity/UdfFunc.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2093/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9VZGZGdW5jLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | ... and [3 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2093/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2093?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2093?src=pr&el=footer). Last update [46f46ed...1f3ac44](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2093?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services