You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Andrew Grieve (JIRA)" <ji...@apache.org> on 2013/09/04 05:33:56 UTC
[jira] [Commented] (CB-4492) Ensure download counts from
plugman-registry are being tracked
[ https://issues.apache.org/jira/browse/CB-4492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757432#comment-13757432 ]
Andrew Grieve commented on CB-4492:
-----------------------------------
Original Commit: https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;a=commit;h=cfa431bc0eca19398a3ca5e3ba79029e42d85104
One question about the code:
{quote}
75 // Update the download count for this plugin.
76 // Fingers crossed that the timestamps are unique, and that no plugin is downloaded
77 // twice in a single millisecond.
{quote}
Where do the milliseconds come into play? I just see day-month-year being inserting into the JSON. Does couch not handle Date objects? is there no syntax to have couch use the server timestamp?
Also wondering if we can have the plugin version included in the download record. That way we can see how many people are upgrading vs. not for a plugin.
> Ensure download counts from plugman-registry are being tracked
> --------------------------------------------------------------
>
> Key: CB-4492
> URL: https://issues.apache.org/jira/browse/CB-4492
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugman
> Reporter: Andrew Grieve
> Assignee: Braden Shepherdson
>
> Don't need to have a dashboard or anything fancy at the start, but we should be able to manually query download counts of plugin fetches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (CB-4492) Ensure download counts from
plugman-registry are being tracked
Posted by David Kemp <dr...@google.com>.
id = pkgId + '_' + now.toISOString() will contain milliseconds
On Tue, Sep 3, 2013 at 11:33 PM, Andrew Grieve (JIRA) <ji...@apache.org>wrote:
>
> [
> https://issues.apache.org/jira/browse/CB-4492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757432#comment-13757432]
>
> Andrew Grieve commented on CB-4492:
> -----------------------------------
>
> Original Commit:
> https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;a=commit;h=cfa431bc0eca19398a3ca5e3ba79029e42d85104
>
> One question about the code:
> {quote}
> 75 // Update the download count for this plugin.
> 76 // Fingers crossed that the timestamps are unique,
> and that no plugin is downloaded
> 77 // twice in a single millisecond.
> {quote}
>
> Where do the milliseconds come into play? I just see day-month-year being
> inserting into the JSON. Does couch not handle Date objects? is there no
> syntax to have couch use the server timestamp?
>
> Also wondering if we can have the plugin version included in the download
> record. That way we can see how many people are upgrading vs. not for a
> plugin.
>
> > Ensure download counts from plugman-registry are being tracked
> > --------------------------------------------------------------
> >
> > Key: CB-4492
> > URL: https://issues.apache.org/jira/browse/CB-4492
> > Project: Apache Cordova
> > Issue Type: Improvement
> > Components: Plugman
> > Reporter: Andrew Grieve
> > Assignee: Braden Shepherdson
> >
> > Don't need to have a dashboard or anything fancy at the start, but we
> should be able to manually query download counts of plugin fetches.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>